Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upEnhance naming of enums #1532
Conversation
jodastephen
requested a review
from
brianweller89
Jul 20, 2017
brianweller89
approved these changes
Jul 21, 2017
Looks fine - assuming the loss of custom parsing logic in the two highlighted enums is expected and known
| // restricted constructor | ||
| private EnumNames(Class<T> enumType, boolean specialToString) { | ||
| ArgChecker.notNull(enumType, "enumType"); |
This comment has been minimized.
This comment has been minimized.
brianweller89
Jul 21, 2017
Contributor
Should use consistent naming when referring to the overridden toString() functionality; currently using "manualToString" in the method name and "specialToString" as the variable name (overriddenToString another option)
| map.put(formatted.toUpperCase(Locale.ENGLISH), value); | ||
| map.put(formatted.toLowerCase(Locale.ENGLISH), value); | ||
| formattedSet.add(formatted); | ||
| formatMap.put(value, formatted); |
This comment has been minimized.
This comment has been minimized.
brianweller89
Jul 21, 2017
Contributor
Can we move these 5 duplicate lines outside of the if/else? Declaring the String outside the if un-itilialised may look abit nasty but IMO in simple cases like this it is better than carrying the risk of having somebody updating one block of code whilst forgetting to update the duplicate.
| * @return the enum value | ||
| */ | ||
| public T parse(String name) { | ||
| ArgChecker.notNull(name, "name"); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| String str = CaseFormat.UPPER_CAMEL.to(CaseFormat.UPPER_UNDERSCORE, uniqueName); | ||
| if (str.endsWith("I_S_D_A")) { | ||
| str = "ORIGINAL_ISDA"; | ||
| } |
This comment has been minimized.
This comment has been minimized.
brianweller89
Jul 21, 2017
Contributor
Assume we are happy for this endsWith logic to be completely removed?
This comment has been minimized.
This comment has been minimized.
| ArgChecker.notNull(uniqueName, "uniqueName"); | ||
| return valueOf(uniqueName.replace('-', '_').replace("/", "").toUpperCase(Locale.ENGLISH)); | ||
| public static FixedCouponBondYieldConvention of(String name) { | ||
| return NAMES.parse(name); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jodastephen commentedJul 20, 2017
Add
NamedEnuminterface, to mark standard enumsAdd
EnumNamesto ensure more lenient and consistent parsingEnhanced performance of parse and format