Abstract swap conventions #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All single currency swap conventions are similar Add additional Guavate method for Optional.or
cjkent
approved these changes
Jul 25, 2017
| * The Java 8 {@link Optional} class does not have an {@code or} method, | ||
| * so this provides an alternative. | ||
| * | ||
| * @param <T> the type of element in the iterable |
| * | ||
| * @param <T> the type of element in the iterable | ||
| * @param suppliers the suppliers to combine | ||
| * @return the list that combines the inputs |
| */ | ||
| @SuppressWarnings("unchecked") | ||
| @SafeVarargs | ||
| public static <T> Optional<T> firstNotEmpty(Supplier<Optional<? extends T>>... suppliers) { |
There was a problem hiding this comment.
The equivalent Guava method for null is called firstNonNull (note "non" instead of "not"). Would it be better to be consistent with that?
| */ | ||
| @SuppressWarnings("unchecked") | ||
| @SafeVarargs | ||
| public static <T> Optional<T> firstNotEmpty(Supplier<Optional<? extends T>>... suppliers) { |
There was a problem hiding this comment.
This method is useful for the use cases in this PR, but would it be worth adding an overload with the signature:
Optional<T> firstNotEmpty(Optional<? extends T>... optionals)
That might be more generally useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All single currency swap conventions are similar, so this creates an abstraction.
Additional
Guavatemethod to simulateOptional.or.