Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upEnhance handling of FX indices #1536
Conversation
jodastephen
assigned
brianweller89
Jul 27, 2017
jodastephen
requested a review
from
brianweller89
Jul 27, 2017
jodastephen
added
the
Status:InReview
label
Jul 27, 2017
brianweller89
approved these changes
Jul 28, 2017
| * <p> | ||
| * The fixing date is the date on which the index is to be observed. | ||
| * The maturity date is the date on which the implied amount is delivered/exchanged. | ||
| * The maturity date is typically two days after the fixing date. |
This comment has been minimized.
This comment has been minimized.
jodastephen
merged commit 8c8a834
into
master
Jul 28, 2017
jodastephen
deleted the
topic/fx
branch
Jul 28, 2017
jodastephen
added
Type:Enhancement
and removed
Status:InReview
labels
Jul 28, 2017
jodastephen
modified the milestone:
v1.4
Jul 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jodastephen commentedJul 27, 2017
Allow fixing offset to be obtained from index
Use it as a default where appropriate