Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance floating rate names #1549

Merged
merged 2 commits into from Sep 1, 2017
Merged

Enhance floating rate names #1549

merged 2 commits into from Sep 1, 2017

Conversation

jodastephen
Copy link
Member

Add missing FloatingRateIndex abstraction
Add default fixed leg day count
Add more flexible parsing methods
Link FloatingRateName and FloatingRateIndex better

Add missing `FloatingRateIndex` abstraction
Add default fixed leg day count
Add more flexible parsing methods
Link `FloatingRateName` and `FloatingRateIndex` better
Tenor tenor = Tenor.parse(row.getValue(TENOR_FIELD));
LocalTime time = LocalTime.parse(row.getValue(FIXING_TIME_FIELD), TIME_FORMAT);
ZoneId zoneId = ZoneId.of(row.getValue(FIXING_ZONE_FIELD));
DayCount fixedLegDayCount = row.findValue(FIXED_LEG_DAY_COUNT).map(s -> DayCount.of(s)).orElse(dayCount);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how safe this defaulting logic is for IBOR? More often than not the DCFS for fixed and float are different.

I don't think it's unreasonable that an explicit fixed DCF must be provided when defining an IBOR index

Force Ibor/Overnight definition files to specify the fixed leg day count
@jodastephen jodastephen merged commit c6ed0d4 into master Sep 1, 2017
@jodastephen jodastephen deleted the topic/floating-rate branch September 1, 2017 09:15
@jodastephen jodastephen added this to the v1.4 milestone Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants