Enhance floating rate names #1549
Merged
Conversation
Add missing `FloatingRateIndex` abstraction Add default fixed leg day count Add more flexible parsing methods Link `FloatingRateName` and `FloatingRateIndex` better
| Tenor tenor = Tenor.parse(row.getValue(TENOR_FIELD)); | ||
| LocalTime time = LocalTime.parse(row.getValue(FIXING_TIME_FIELD), TIME_FORMAT); | ||
| ZoneId zoneId = ZoneId.of(row.getValue(FIXING_ZONE_FIELD)); | ||
| DayCount fixedLegDayCount = row.findValue(FIXED_LEG_DAY_COUNT).map(s -> DayCount.of(s)).orElse(dayCount); |
brianweller89
Aug 30, 2017
Contributor
I wonder how safe this defaulting logic is for IBOR? More often than not the DCFS for fixed and float are different.
I don't think it's unreasonable that an explicit fixed DCF must be provided when defining an IBOR index
I wonder how safe this defaulting logic is for IBOR? More often than not the DCFS for fixed and float are different.
I don't think it's unreasonable that an explicit fixed DCF must be provided when defining an IBOR index
Force Ibor/Overnight definition files to specify the fixed leg day count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Add missing
FloatingRateIndexabstractionAdd default fixed leg day count
Add more flexible parsing methods
Link
FloatingRateNameandFloatingRateIndexbetter