Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ability to identify Strata CSV format #1559

Merged
merged 2 commits into from Sep 13, 2017

Conversation

jodastephen
Copy link
Member

Change column name to be sufficiently unique

Change column name to be sufficiently unique
@@ -280,7 +298,7 @@ private TradeCsvLoader(ReferenceData refData) {
try (CsvIterator csv = CsvIterator.of(charSource, true)) {
if (!csv.headers().contains(TYPE_FIELD)) {
return ValueWithFailures.of(ImmutableList.of(),
FailureItem.of(FailureReason.PARSING, "CSV file does not contain 'Type' header: {}", charSource));
FailureItem.of(FailureReason.PARSING, "CSV file does not contain '" + TYPE_FIELD + "' header: {}", charSource));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be:

FailureItem.of(FailureReason.PARSING, "CSV file does not contain '{}' header: {}", TYPE_FIELD, charSource));

Change column name to be sufficiently unique
@jodastephen jodastephen merged commit 5d2063f into master Sep 13, 2017
@jodastephen jodastephen deleted the topic/is-known-format branch September 13, 2017 15:43
@jodastephen jodastephen added this to the v1.4 milestone Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants