Provide ability to identify Strata CSV format #1559
Merged
Conversation
Change column name to be sufficiently unique
| @@ -280,7 +298,7 @@ private TradeCsvLoader(ReferenceData refData) { | |||
| try (CsvIterator csv = CsvIterator.of(charSource, true)) { | |||
| if (!csv.headers().contains(TYPE_FIELD)) { | |||
| return ValueWithFailures.of(ImmutableList.of(), | |||
| FailureItem.of(FailureReason.PARSING, "CSV file does not contain 'Type' header: {}", charSource)); | |||
| FailureItem.of(FailureReason.PARSING, "CSV file does not contain '" + TYPE_FIELD + "' header: {}", charSource)); | |||
cjkent
Sep 13, 2017
Member
Shouldn't this be:
FailureItem.of(FailureReason.PARSING, "CSV file does not contain '{}' header: {}", TYPE_FIELD, charSource));
Shouldn't this be:
FailureItem.of(FailureReason.PARSING, "CSV file does not contain '{}' header: {}", TYPE_FIELD, charSource));
Change column name to be sufficiently unique
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Change column name to be sufficiently unique