New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ability to identify Strata CSV format #1559

Merged
merged 2 commits into from Sep 13, 2017

Conversation

Projects
None yet
2 participants
@jodastephen
Member

jodastephen commented Sep 13, 2017

Change column name to be sufficiently unique

Provide ability to identify Strata CSV format
Change column name to be sufficiently unique

@jodastephen jodastephen requested a review from cjkent Sep 13, 2017

@cjkent

cjkent approved these changes Sep 13, 2017

@@ -280,7 +298,7 @@ private TradeCsvLoader(ReferenceData refData) {
try (CsvIterator csv = CsvIterator.of(charSource, true)) {
if (!csv.headers().contains(TYPE_FIELD)) {
return ValueWithFailures.of(ImmutableList.of(),
FailureItem.of(FailureReason.PARSING, "CSV file does not contain 'Type' header: {}", charSource));
FailureItem.of(FailureReason.PARSING, "CSV file does not contain '" + TYPE_FIELD + "' header: {}", charSource));

This comment has been minimized.

@cjkent

cjkent Sep 13, 2017

Member

Shouldn't this be:

FailureItem.of(FailureReason.PARSING, "CSV file does not contain '{}' header: {}", TYPE_FIELD, charSource));
Provide ability to identify Strata CSV format
Change column name to be sufficiently unique

@jodastephen jodastephen merged commit 5d2063f into master Sep 13, 2017

15 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new issues
Details
security/snyk - modules/basics/pom.xml No new issues
Details
security/snyk - modules/calc/pom.xml No new issues
Details
security/snyk - modules/collect/pom.xml No new issues
Details
security/snyk - modules/data/pom.xml No new issues
Details
security/snyk - modules/loader/pom.xml No new issues
Details
security/snyk - modules/market/pom.xml No new issues
Details
security/snyk - modules/math/pom.xml No new issues
Details
security/snyk - modules/measure/pom.xml No new issues
Details
security/snyk - modules/pom.xml No new issues
Details
security/snyk - modules/pricer/pom.xml No new issues
Details
security/snyk - modules/product/pom.xml No new issues
Details
security/snyk - modules/report/pom.xml No new issues
Details

@jodastephen jodastephen deleted the topic/is-known-format branch Sep 13, 2017

@jodastephen jodastephen added this to the v1.4 milestone Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment