Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upProvide ability to identify Strata CSV format #1559
Conversation
jodastephen
assigned
cjkent
Sep 13, 2017
jodastephen
requested a review
from
cjkent
Sep 13, 2017
| @@ -280,7 +298,7 @@ private TradeCsvLoader(ReferenceData refData) { | ||
| try (CsvIterator csv = CsvIterator.of(charSource, true)) { | ||
| if (!csv.headers().contains(TYPE_FIELD)) { | ||
| return ValueWithFailures.of(ImmutableList.of(), | ||
| FailureItem.of(FailureReason.PARSING, "CSV file does not contain 'Type' header: {}", charSource)); | ||
| FailureItem.of(FailureReason.PARSING, "CSV file does not contain '" + TYPE_FIELD + "' header: {}", charSource)); |
This comment has been minimized.
This comment has been minimized.
cjkent
Sep 13, 2017
Member
Shouldn't this be:
FailureItem.of(FailureReason.PARSING, "CSV file does not contain '{}' header: {}", TYPE_FIELD, charSource));
jodastephen
merged commit 5d2063f
into
master
Sep 13, 2017
15 checks passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
security/snyk
No new issues
Details
security/snyk - modules/basics/pom.xml
No new issues
Details
security/snyk - modules/calc/pom.xml
No new issues
Details
security/snyk - modules/collect/pom.xml
No new issues
Details
security/snyk - modules/data/pom.xml
No new issues
Details
security/snyk - modules/loader/pom.xml
No new issues
Details
security/snyk - modules/market/pom.xml
No new issues
Details
security/snyk - modules/math/pom.xml
No new issues
Details
security/snyk - modules/measure/pom.xml
No new issues
Details
security/snyk - modules/pom.xml
No new issues
Details
security/snyk - modules/pricer/pom.xml
No new issues
Details
security/snyk - modules/product/pom.xml
No new issues
Details
security/snyk - modules/report/pom.xml
No new issues
Details
jodastephen
deleted the
topic/is-known-format
branch
Sep 13, 2017
jodastephen
added this to the v1.4 milestone
Sep 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jodastephen commentedSep 13, 2017
Change column name to be sufficiently unique