Add new plus/minus methods for combining CurrencyScenarioArrays #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodastephen
approved these changes
Oct 6, 2017
| * The currency must be the same as the currency of this array. | ||
| * | ||
| * @param amount the amount to add | ||
| * @return a new array containing the values from this array added to the values in the other array |
| * The arrays must have the same size. | ||
| * | ||
| * @param other another array of multiple currency values. | ||
| * @return a new array containing the values from this array added with the values from the other array subtracted |
There was a problem hiding this comment.
Confession time; I copy/pasted all of these new Javadoc from CurrencyAmountArray!
Will clean that up as well.
| * The currency must be the same as the currency of this array. | ||
| * | ||
| * @param amount the amount to subtract | ||
| * @return a new array containing the values from this array with the values from the amount subtracted |
There was a problem hiding this comment.
What's wrong with this one? Only issue I can see is 'values' rather than value
There was a problem hiding this comment.
@return a new array containing the values from this array with the specified amount subtracted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.