New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new plus/minus methods for combining CurrencyScenarioArrays #1577

Merged
merged 2 commits into from Oct 6, 2017

Conversation

Projects
None yet
2 participants
@brianweller89
Copy link
Contributor

brianweller89 commented Oct 5, 2017

No description provided.

* The currency must be the same as the currency of this array.
*
* @param amount the amount to add
* @return a new array containing the values from this array added to the values in the other array

This comment has been minimized.

@jodastephen

jodastephen Oct 6, 2017

Member

Not quite right

* The arrays must have the same size.
*
* @param other another array of multiple currency values.
* @return a new array containing the values from this array added with the values from the other array subtracted

This comment has been minimized.

@jodastephen

jodastephen Oct 6, 2017

Member

Not "added"

This comment has been minimized.

@brianweller89

brianweller89 Oct 6, 2017

Contributor

Confession time; I copy/pasted all of these new Javadoc from CurrencyAmountArray!

Will clean that up as well.

* The currency must be the same as the currency of this array.
*
* @param amount the amount to subtract
* @return a new array containing the values from this array with the values from the amount subtracted

This comment has been minimized.

@jodastephen

jodastephen Oct 6, 2017

Member

Not quite right

This comment has been minimized.

@brianweller89

brianweller89 Oct 6, 2017

Contributor

What's wrong with this one? Only issue I can see is 'values' rather than value

This comment has been minimized.

@jodastephen

jodastephen Oct 6, 2017

Member

@return a new array containing the values from this array with the specified amount subtracted

@brianweller89 brianweller89 merged commit 84dd0b1 into master Oct 6, 2017

15 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new issues
Details
security/snyk - modules/basics/pom.xml No new issues
Details
security/snyk - modules/calc/pom.xml No new issues
Details
security/snyk - modules/collect/pom.xml No new issues
Details
security/snyk - modules/data/pom.xml No new issues
Details
security/snyk - modules/loader/pom.xml No new issues
Details
security/snyk - modules/market/pom.xml No new issues
Details
security/snyk - modules/math/pom.xml No new issues
Details
security/snyk - modules/measure/pom.xml No new issues
Details
security/snyk - modules/pom.xml No new issues
Details
security/snyk - modules/pricer/pom.xml No new issues
Details
security/snyk - modules/product/pom.xml No new issues
Details
security/snyk - modules/report/pom.xml No new issues
Details

@brianweller89 brianweller89 deleted the topic/CurrencyScenarioArrayMaths branch Oct 19, 2017

@jodastephen jodastephen added this to the v1.5 milestone Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment