Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the ability to control payment periods #1581

Merged
merged 2 commits into from Oct 23, 2017

Conversation

jodastephen
Copy link
Member

Add firstRegularStartDate and lastRegularEndDate to PaymentSchedule
Update FpML and CSV trade parser

Add firstRegularStartDate and lastRegularEndDate to PaymentSchedule
Update FpML and CSV trade parser
*/
public ImmutableList<LocalDate> getUnadjustedDates() {
ImmutableList.Builder<LocalDate> dates = ImmutableList.builder();
dates.add(periods.get(0).getUnadjustedStartDate());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just the logic of getUnadjustedStartDate(), so could call that directly

* Gets the complete list of unadjusted dates.
* <p>
* This returns a list including all the unadjusted period boundary dates.
* This is the same as the unadjusted start date of each period plus the final unadjusted end date.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal but it reads a little odd that the comment refers to the list as start date of all periods + final end date whereas the code works off the opposite logic (start date of first period + all end dates)

@brianweller89 brianweller89 merged commit 403152a into master Oct 23, 2017
@brianweller89 brianweller89 deleted the topic/payment-period-control branch October 23, 2017 15:46
@jodastephen jodastephen added this to the v1.5 milestone Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants