New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the ability to control payment periods #1581

Merged
merged 2 commits into from Oct 23, 2017

Conversation

Projects
None yet
2 participants
@jodastephen
Member

jodastephen commented Oct 23, 2017

Add firstRegularStartDate and lastRegularEndDate to PaymentSchedule
Update FpML and CSV trade parser

Provide the ability to control payment periods
Add firstRegularStartDate and lastRegularEndDate to PaymentSchedule
Update FpML and CSV trade parser
*/
public ImmutableList<LocalDate> getUnadjustedDates() {
ImmutableList.Builder<LocalDate> dates = ImmutableList.builder();
dates.add(periods.get(0).getUnadjustedStartDate());

This comment has been minimized.

@brianweller89

brianweller89 Oct 23, 2017

Contributor

this is just the logic of getUnadjustedStartDate(), so could call that directly

* Gets the complete list of unadjusted dates.
* <p>
* This returns a list including all the unadjusted period boundary dates.
* This is the same as the unadjusted start date of each period plus the final unadjusted end date.

This comment has been minimized.

@brianweller89

brianweller89 Oct 23, 2017

Contributor

Not a big deal but it reads a little odd that the comment refers to the list as start date of all periods + final end date whereas the code works off the opposite logic (start date of first period + all end dates)

@brianweller89 brianweller89 merged commit 403152a into master Oct 23, 2017

15 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new issues
Details
security/snyk - modules/basics/pom.xml No new issues
Details
security/snyk - modules/calc/pom.xml No new issues
Details
security/snyk - modules/collect/pom.xml No new issues
Details
security/snyk - modules/data/pom.xml No new issues
Details
security/snyk - modules/loader/pom.xml No new issues
Details
security/snyk - modules/market/pom.xml No new issues
Details
security/snyk - modules/math/pom.xml No new issues
Details
security/snyk - modules/measure/pom.xml No new issues
Details
security/snyk - modules/pom.xml No new issues
Details
security/snyk - modules/pricer/pom.xml No new issues
Details
security/snyk - modules/product/pom.xml No new issues
Details
security/snyk - modules/report/pom.xml No new issues
Details

@brianweller89 brianweller89 deleted the topic/payment-period-control branch Oct 23, 2017

@jodastephen jodastephen added this to the v1.5 milestone Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment