New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend position CSV parsing #1584

Merged
merged 2 commits into from Oct 26, 2017

Conversation

Projects
None yet
2 participants
@jodastephen
Member

jodastephen commented Oct 24, 2017

Add mode whereby ETD positions can be parsed as SecurityPosition without using reference data

CsvLoaderUtils is existing code that has been moved.

Extend position CSV parsing
Add mode whereby ETD positions can be parsed as `SecurityPosition`
without using reference data

@jodastephen jodastephen requested a review from cjkent Oct 24, 2017

* Parses an ETD future position from the CSV row.
* <p>
* In most cases this will return {@link EtdFuturePosition}, however for flexibility
* it is allowed to return any position, such as {@link SecurityPosition}.

This comment has been minimized.

@cjkent

cjkent Oct 24, 2017

Member

The comment doesn't match the return type. Should it actually return Position like the method below?

@cjkent

cjkent approved these changes Oct 26, 2017

@cjkent cjkent merged commit 894535c into master Oct 26, 2017

15 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new issues
Details
security/snyk - modules/basics/pom.xml No new issues
Details
security/snyk - modules/calc/pom.xml No new issues
Details
security/snyk - modules/collect/pom.xml No new issues
Details
security/snyk - modules/data/pom.xml No new issues
Details
security/snyk - modules/loader/pom.xml No new issues
Details
security/snyk - modules/market/pom.xml No new issues
Details
security/snyk - modules/math/pom.xml No new issues
Details
security/snyk - modules/measure/pom.xml No new issues
Details
security/snyk - modules/pom.xml No new issues
Details
security/snyk - modules/pricer/pom.xml No new issues
Details
security/snyk - modules/product/pom.xml No new issues
Details
security/snyk - modules/report/pom.xml No new issues
Details

@cjkent cjkent deleted the topic/position-csv branch Oct 26, 2017

@jodastephen jodastephen added this to the v1.5 milestone Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment