Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend position CSV parsing #1584

Merged
merged 2 commits into from Oct 26, 2017
Merged

Extend position CSV parsing #1584

merged 2 commits into from Oct 26, 2017

Conversation

jodastephen
Copy link
Member

Add mode whereby ETD positions can be parsed as SecurityPosition without using reference data

CsvLoaderUtils is existing code that has been moved.

Add mode whereby ETD positions can be parsed as `SecurityPosition`
without using reference data
* Parses an ETD future position from the CSV row.
* <p>
* In most cases this will return {@link EtdFuturePosition}, however for flexibility
* it is allowed to return any position, such as {@link SecurityPosition}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment doesn't match the return type. Should it actually return Position like the method below?

@cjkent cjkent merged commit 894535c into master Oct 26, 2017
@cjkent cjkent deleted the topic/position-csv branch October 26, 2017 09:11
@jodastephen jodastephen added this to the v1.5 milestone Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants