New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend quoting of CSV output #1586

Merged
merged 2 commits into from Oct 25, 2017

Conversation

Projects
None yet
2 participants
@jodastephen
Member

jodastephen commented Oct 25, 2017

If a CSV entry starts with an expression prefix character
then prefix the quoted section by equals
This is invalid pure CSV, but accepted by Excel/Google
to indicate a test formatted cell
Update CSV input to parse equals prefix format

Extend quoting of CSV output
If a CSV entry starts with an expression prefix character
then prefix the quoted section by equals
This is invalid pure CSV, but accepted by Excel/Google
to indicate a test formatted cell
Update CSV input to parse equals prefix format
}
private boolean isExpressionPrefix(String entry) {
char first = entry.length() == 0 ? ' ' : entry.charAt(0);

This comment has been minimized.

@brianweller89

brianweller89 Oct 25, 2017

Contributor

Feels odd to be assigning empty char here given we know empty char will always return false in the subsequent check. Admittedly the alternatives would require more code but this is abit random IMO.

@jodastephen jodastephen merged commit b41c886 into master Oct 25, 2017

15 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new issues
Details
security/snyk - modules/basics/pom.xml No new issues
Details
security/snyk - modules/calc/pom.xml No new issues
Details
security/snyk - modules/collect/pom.xml No new issues
Details
security/snyk - modules/data/pom.xml No new issues
Details
security/snyk - modules/loader/pom.xml No new issues
Details
security/snyk - modules/market/pom.xml No new issues
Details
security/snyk - modules/math/pom.xml No new issues
Details
security/snyk - modules/measure/pom.xml No new issues
Details
security/snyk - modules/pom.xml No new issues
Details
security/snyk - modules/pricer/pom.xml No new issues
Details
security/snyk - modules/product/pom.xml No new issues
Details
security/snyk - modules/report/pom.xml No new issues
Details

@jodastephen jodastephen deleted the topic/csv branch Oct 25, 2017

@jodastephen jodastephen added this to the v1.5 milestone Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment