New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup fixed DCF default for some indices #1592

Merged
merged 2 commits into from Oct 30, 2017

Conversation

Projects
None yet
2 participants
@brianweller89
Contributor

brianweller89 commented Oct 30, 2017

HUX, CZK and MXN fixed defaults are currently incorrect in Strata.

Have reconciled two sources which both agree that the new values are correct:

  • LCH index conventions file
  • BBG rulebook and termsheets
    • MXN described on page 129 of the BBG SEF rulebook
    • HUF and CZK values taken from example termsheets. Fixed DCF is on final page

USD has also been changed from 30/360 to Act/360. LCH define the USD LIBOR default as Act/360, but the SEF rulebook listed above lists both options as acceptable values (page 124). Hence the existing Strata default would still be considered correct. However it has been updated for consistency with LCH.

@jodastephen jodastephen merged commit 1232b70 into master Oct 30, 2017

16 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new issues
Details
security/snyk - modules/basics/pom.xml No new issues
Details
security/snyk - modules/calc/pom.xml No new issues
Details
security/snyk - modules/collect/pom.xml No new issues
Details
security/snyk - modules/data/pom.xml No new issues
Details
security/snyk - modules/loader/pom.xml No new issues
Details
security/snyk - modules/market/pom.xml No new issues
Details
security/snyk - modules/math/pom.xml No new issues
Details
security/snyk - modules/measure/pom.xml No new issues
Details
security/snyk - modules/pom.xml No new issues
Details
security/snyk - modules/pricer/pom.xml No new issues
Details
security/snyk - modules/product/pom.xml No new issues
Details
security/snyk - modules/report/pom.xml No new issues
Details

@brianweller89 brianweller89 deleted the topic/index_cleanup branch Oct 31, 2017

@jodastephen jodastephen added this to the v1.6 milestone Nov 6, 2017

@jodastephen jodastephen added the Type:Bug label Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment