Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conventional currency pair for EUR/GBP swap #1595

Merged
merged 2 commits into from Nov 6, 2017

Conversation

@yukiiwashita
Copy link
Contributor

@yukiiwashita yukiiwashita commented Nov 6, 2017

The currency pair in EUR/GBP swap should be conventional.

@yukiiwashita yukiiwashita requested a review from jodastephen Nov 6, 2017
*/
public static final FxSwapConvention GBP_EUR =
FxSwapConvention.of(StandardFxSwapConventions.GBP_EUR.getName());
public static final FxSwapConvention EUR_GBP =

This comment has been minimized.

@jodastephen

jodastephen Nov 6, 2017
Member

You'll need to keep the old one, but deprecated.

@yukiiwashita yukiiwashita merged commit 9e3afdc into master Nov 6, 2017
15 checks passed
15 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new issues
Details
security/snyk - modules/basics/pom.xml No new issues
Details
security/snyk - modules/calc/pom.xml No new issues
Details
security/snyk - modules/collect/pom.xml No new issues
Details
security/snyk - modules/data/pom.xml No new issues
Details
security/snyk - modules/loader/pom.xml No new issues
Details
security/snyk - modules/market/pom.xml No new issues
Details
security/snyk - modules/math/pom.xml No new issues
Details
security/snyk - modules/measure/pom.xml No new issues
Details
security/snyk - modules/pom.xml No new issues
Details
security/snyk - modules/pricer/pom.xml No new issues
Details
security/snyk - modules/product/pom.xml No new issues
Details
security/snyk - modules/report/pom.xml No new issues
Details
@yukiiwashita yukiiwashita deleted the topic/eur-gbp-swap-convention branch Nov 6, 2017
@jodastephen jodastephen added this to the v1.6 milestone Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants