Adding Quote object and unit test #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodastephen
requested changes
Nov 21, 2017
| * | ||
| * This represents a single numeric value of a given security, such as the mid point between the buy/sell. | ||
| * <p> | ||
| * See {@link QuoteId} fot the representation that does not contain a value. |
There was a problem hiding this comment.
fot -> for, although I'm not sure this line is adding anything, so best to remove
| /** | ||
| * A single value for a given security, represented by a quote, such as 'EUR/GBP 1W FX Opt ATM Straddle' - 10.0. | ||
| * <p> | ||
| * |
| /** | ||
| * Obtains an instance from a the scheme ID, quote ID, and value. | ||
| * | ||
| * @param identifierScheme the identifier of the scheme used to indicate the quote |
There was a problem hiding this comment.
In Strata there are two spaces after the parameter name, so @param xxx<two spaces here>description
| * @return an instance of {@link Quote} for the given values | ||
| * @throws IllegalArgumentException if the scheme ID, or scheme value are empty | ||
| */ | ||
| public static Quote of(String identifierScheme, String identifier, Double value) { |
There was a problem hiding this comment.
Should be double, not Double.
| * The value applicable for the given {@link QuoteId}. | ||
| */ | ||
| @PropertyDefinition(validate = "notNull") | ||
| private final Double value; |
There was a problem hiding this comment.
Should be double not Double
|
|
||
| @Test | ||
| public class QuoteTest { | ||
| private static final QuoteId quoteId1 = QuoteId.of(StandardId.of("og", "id1")); |
There was a problem hiding this comment.
constants should be upper case quoteId1 -> QUOTE_ID1
| public void test_of_EmptyId() throws Exception { | ||
| Quote.of("notEmpty", "", 1.2345); | ||
| } | ||
| } |
| Quote.of("", "notEmpty", 1.2345); | ||
| } | ||
|
|
||
| @Test(expectedExceptions = IllegalArgumentException.class, expectedExceptionsMessageRegExp = "Argument 'value' with value '' must match pattern:.+") |
There was a problem hiding this comment.
Strata uses assertThrowsIllegalArg(lambda, regex) for cases like these. Both error cases can then be in one method
jodastephen
approved these changes
Nov 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be a simple wrapper of a
QuoteIdand a double value.A similar example is
FxRatewrappingFxRateIdand the actual rate.