New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide human-readable summaries #1626

Merged
merged 2 commits into from Dec 15, 2017

Conversation

Projects
None yet
2 participants
@jodastephen
Member

jodastephen commented Dec 15, 2017

Add basic structure for Trades and Positions

Provide human-readable summaries
Add basic structure for Trades and Positions

@jodastephen jodastephen requested a review from cjkent Dec 15, 2017

@cjkent

cjkent approved these changes Dec 15, 2017

@PropertyDefinition(validate = "notNull")
private final PortfolioItemType portfolioItemType;
/**
* The type of the item.

This comment has been minimized.

@cjkent

cjkent Dec 15, 2017

Member

Should this be "...the item's product"?

/**
* The description of the item.
*/
@PropertyDefinition(validate = "notNull")

This comment has been minimized.

@cjkent

cjkent Dec 15, 2017

Member

Can this be empty? Should it be notBlank?

* <p>
* This allows trades and positions to be separated.
*/
public enum PortfolioItemType implements NamedEnum {

This comment has been minimized.

@cjkent

cjkent Dec 15, 2017

Member

Is it worth having a value for SENSITIVITIES? We know we have those in our portfolios. Or are we OK with them being OTHER?

/**
* A {@link FxSingleBarrierOption}.
*/
public static final ProductType FX_SINGLE_BARRIER_OPTION = ProductType.of("FxSingleBarrierOption", "FX Single Barrier");

This comment has been minimized.

@cjkent

cjkent Dec 15, 2017

Member

Should the description include "Option"?

*/
private ProductType(String name, String description) {
super(name);
this.description = ArgChecker.notEmpty(description, "description");

This comment has been minimized.

@cjkent

cjkent Dec 15, 2017

Member

notBlank? notEmpty allows a string with nothing but whitespace.

this.description = ArgChecker.notEmpty(description, "description");
}
public String getDescription() {

This comment has been minimized.

@cjkent

cjkent Dec 15, 2017

Member

Javadoc

@jodastephen jodastephen merged commit 49a117e into master Dec 15, 2017

15 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new issues
Details
security/snyk - modules/basics/pom.xml No new issues
Details
security/snyk - modules/calc/pom.xml No new issues
Details
security/snyk - modules/collect/pom.xml No new issues
Details
security/snyk - modules/data/pom.xml No new issues
Details
security/snyk - modules/loader/pom.xml No new issues
Details
security/snyk - modules/market/pom.xml No new issues
Details
security/snyk - modules/math/pom.xml No new issues
Details
security/snyk - modules/measure/pom.xml No new issues
Details
security/snyk - modules/pom.xml No new issues
Details
security/snyk - modules/pricer/pom.xml No new issues
Details
security/snyk - modules/product/pom.xml No new issues
Details
security/snyk - modules/report/pom.xml No new issues
Details

@jodastephen jodastephen deleted the topic/summary1 branch Dec 15, 2017

@jodastephen jodastephen added this to the v1.7 milestone Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment