Provide human-readable summaries #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add basic structure for Trades and Positions
cjkent
approved these changes
Dec 15, 2017
| @PropertyDefinition(validate = "notNull") | ||
| private final PortfolioItemType portfolioItemType; | ||
| /** | ||
| * The type of the item. |
There was a problem hiding this comment.
Should this be "...the item's product"?
| /** | ||
| * The description of the item. | ||
| */ | ||
| @PropertyDefinition(validate = "notNull") |
There was a problem hiding this comment.
Can this be empty? Should it be notBlank?
| * <p> | ||
| * This allows trades and positions to be separated. | ||
| */ | ||
| public enum PortfolioItemType implements NamedEnum { |
There was a problem hiding this comment.
Is it worth having a value for SENSITIVITIES? We know we have those in our portfolios. Or are we OK with them being OTHER?
| /** | ||
| * A {@link FxSingleBarrierOption}. | ||
| */ | ||
| public static final ProductType FX_SINGLE_BARRIER_OPTION = ProductType.of("FxSingleBarrierOption", "FX Single Barrier"); |
There was a problem hiding this comment.
Should the description include "Option"?
| */ | ||
| private ProductType(String name, String description) { | ||
| super(name); | ||
| this.description = ArgChecker.notEmpty(description, "description"); |
There was a problem hiding this comment.
notBlank? notEmpty allows a string with nothing but whitespace.
| this.description = ArgChecker.notEmpty(description, "description"); | ||
| } | ||
|
|
||
| public String getDescription() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic structure for Trades and Positions