Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide human-readable summaries #1627

Merged
merged 1 commit into from Dec 19, 2017

Conversation

Projects
None yet
2 participants
@jodastephen
Copy link
Member

jodastephen commented Dec 15, 2017

Summaries for Positions

Provide human-readable summaries
Trades and Positions

@jodastephen jodastephen force-pushed the topic/summary2 branch from e63eaa0 to df35641 Dec 18, 2017

* @return the summary description
*/
public String summaryDescription() {
return expiry.format(YM_FORMAT) + variant.getCode();

This comment has been minimized.

@brianweller89

brianweller89 Dec 19, 2017

Contributor

Seems odd that the summary description for a future security doesn't include some form of contract identifier?

This comment has been minimized.

@jodastephen

jodastephen Dec 19, 2017

Author Member

The full description includes the ID - <ID> x <quantity>, <etddescription>. So this is only part of the story.

versionCode +
putCallStr +
strikeStr;
}

This comment has been minimized.

@brianweller89

brianweller89 Dec 19, 2017

Contributor

Similar to above, why doesn't this include the id?

@jodastephen jodastephen merged commit 4fb9f5c into master Dec 19, 2017

15 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new issues
Details
security/snyk - modules/basics/pom.xml No new issues
Details
security/snyk - modules/calc/pom.xml No new issues
Details
security/snyk - modules/collect/pom.xml No new issues
Details
security/snyk - modules/data/pom.xml No new issues
Details
security/snyk - modules/loader/pom.xml No new issues
Details
security/snyk - modules/market/pom.xml No new issues
Details
security/snyk - modules/math/pom.xml No new issues
Details
security/snyk - modules/measure/pom.xml No new issues
Details
security/snyk - modules/pom.xml No new issues
Details
security/snyk - modules/pricer/pom.xml No new issues
Details
security/snyk - modules/product/pom.xml No new issues
Details
security/snyk - modules/report/pom.xml No new issues
Details

@jodastephen jodastephen deleted the topic/summary2 branch Dec 19, 2017

@jodastephen jodastephen added this to the v1.7 milestone Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.