Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide human-readable summaries #1627

Merged
merged 1 commit into from Dec 19, 2017
Merged

Provide human-readable summaries #1627

merged 1 commit into from Dec 19, 2017

Conversation

jodastephen
Copy link
Member

Summaries for Positions

Trades and Positions
* @return the summary description
*/
public String summaryDescription() {
return expiry.format(YM_FORMAT) + variant.getCode();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems odd that the summary description for a future security doesn't include some form of contract identifier?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full description includes the ID - <ID> x <quantity>, <etddescription>. So this is only part of the story.

versionCode +
putCallStr +
strikeStr;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to above, why doesn't this include the id?

@jodastephen jodastephen merged commit 4fb9f5c into master Dec 19, 2017
@jodastephen jodastephen deleted the topic/summary2 branch December 19, 2017 11:25
@jodastephen jodastephen added this to the v1.7 milestone Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants