New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control FX more effectively (FxRateLookup) #1666

Merged
merged 2 commits into from Mar 22, 2018

Conversation

Projects
None yet
2 participants
@jodastephen
Member

jodastephen commented Mar 16, 2018

Move FxRateLookup to strata-calc and extend CakculationParameter
Change CalculationTask to use parameter
Extend CalculationParameters to search parent interfaces

This is a backwards incompatible change, however serialized instances of RatesMarketDataLookup will deserialize fine. Fixing the incompatibility simply requires an organize imports.

Control FX more effectively
Move `FxRateLookup` to strata-calc and extend `CakculationParameter`
Change `CalculationTask` to use parameter
Extend `CalculationParameters` to search parent interfaces

@jodastephen jodastephen merged commit 8cb837a into master Mar 22, 2018

15 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No dependency changes
Details
security/snyk - modules/basics/pom.xml No dependency changes
Details
security/snyk - modules/calc/pom.xml No dependency changes
Details
security/snyk - modules/collect/pom.xml No dependency changes
Details
security/snyk - modules/data/pom.xml No dependency changes
Details
security/snyk - modules/loader/pom.xml No dependency changes
Details
security/snyk - modules/market/pom.xml No dependency changes
Details
security/snyk - modules/math/pom.xml No dependency changes
Details
security/snyk - modules/measure/pom.xml No dependency changes
Details
security/snyk - modules/pom.xml No dependency changes
Details
security/snyk - modules/pricer/pom.xml No dependency changes
Details
security/snyk - modules/product/pom.xml No dependency changes
Details
security/snyk - modules/report/pom.xml No dependency changes
Details

@jodastephen jodastephen deleted the topic/fx-lookup branch Mar 22, 2018

jodastephen added a commit that referenced this pull request Mar 22, 2018

Control FX more effectively (#1666)
* Control FX more effectively

Move `FxRateLookup` to strata-calc and extend `CakculationParameter`
Change `CalculationTask` to use parameter
Extend `CalculationParameters` to search parent interfaces

* Update from PR

@jodastephen jodastephen added this to the v1.8 milestone Apr 9, 2018

@jodastephen jodastephen modified the milestones: v1.8, v2.0 Jun 12, 2018

@jodastephen jodastephen changed the title from Control FX more effectively to Control FX more effectively (FxRateLookup) Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment