Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security quantity trade #1667

Merged
merged 2 commits into from Mar 21, 2018
Merged

Security quantity trade #1667

merged 2 commits into from Mar 21, 2018

Conversation

yukiiwashita
Copy link
Contributor

  • Allow for creating a trade with quantity altered for any trades with quantity field.

*
* @return the price
*/
public abstract double getPrice();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness, a withPrice() would make sense

@yukiiwashita yukiiwashita merged commit fd75aa1 into master Mar 21, 2018
@yukiiwashita yukiiwashita deleted the topic/security-trade-quantity branch March 21, 2018 12:53
jodastephen pushed a commit that referenced this pull request Mar 22, 2018
* security quantity trade

* add withPrice
@jodastephen jodastephen added this to the v1.8 milestone Apr 9, 2018
@jodastephen jodastephen modified the milestones: v1.8, v2.0 Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants