Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security quantity trade #1667

Merged
merged 2 commits into from Mar 21, 2018
Merged

Security quantity trade #1667

merged 2 commits into from Mar 21, 2018

Conversation

@yukiiwashita
Copy link
Contributor

@yukiiwashita yukiiwashita commented Mar 20, 2018

  • Allow for creating a trade with quantity altered for any trades with quantity field.
*
* @return the price
*/
public abstract double getPrice();

This comment has been minimized.

@jodastephen

jodastephen Mar 21, 2018
Member

For completeness, a withPrice() would make sense

@yukiiwashita yukiiwashita merged commit fd75aa1 into master Mar 21, 2018
15 checks passed
15 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No dependency changes
Details
security/snyk - modules/basics/pom.xml No dependency changes
Details
security/snyk - modules/calc/pom.xml No dependency changes
Details
security/snyk - modules/collect/pom.xml No dependency changes
Details
security/snyk - modules/data/pom.xml No dependency changes
Details
security/snyk - modules/loader/pom.xml No dependency changes
Details
security/snyk - modules/market/pom.xml No dependency changes
Details
security/snyk - modules/math/pom.xml No dependency changes
Details
security/snyk - modules/measure/pom.xml No dependency changes
Details
security/snyk - modules/pom.xml No dependency changes
Details
security/snyk - modules/pricer/pom.xml No dependency changes
Details
security/snyk - modules/product/pom.xml No dependency changes
Details
security/snyk - modules/report/pom.xml No dependency changes
Details
@yukiiwashita yukiiwashita deleted the topic/security-trade-quantity branch Mar 21, 2018
jodastephen added a commit that referenced this pull request Mar 22, 2018
* security quantity trade

* add withPrice
@jodastephen jodastephen added this to the v1.8 milestone Apr 9, 2018
@jodastephen jodastephen modified the milestones: v1.8, v2.0 Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants