Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamma calculation with combined curve #1680

Merged
merged 1 commit into from May 8, 2018

Conversation

@yukiiwashita
Copy link
Contributor

@yukiiwashita yukiiwashita commented May 4, 2018

  • Split a curve into underlying curves in the curve gamma calculator
result = result.combinedWith(gammaSingle);
} else if (curve.split().size() > 1) {
Copy link
Member

@jodastephen jodastephen May 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this just be a foreach loop of the split curves? Won't that handle the non-combined case?

Loading

Copy link
Contributor Author

@yukiiwashita yukiiwashita May 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The underlying curves should be checked only when a sensitivity object is not found, because CurrencyParameterSensitivity is not necessarily split.

Loading

@yukiiwashita yukiiwashita merged commit 68b8199 into master May 8, 2018
15 checks passed
Loading
@yukiiwashita yukiiwashita deleted the topic/split-curve-gamma-calculator branch May 8, 2018
@jodastephen jodastephen added this to the v1.8 milestone Jun 5, 2018
@jodastephen jodastephen removed this from the v1.8 milestone Jun 12, 2018
@jodastephen jodastephen added this to the v2.0 milestone Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants