Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for currency rounding #1689

Merged
merged 1 commit into from May 15, 2018
Merged

Better support for currency rounding #1689

merged 1 commit into from May 15, 2018

Conversation

@jodastephen
Copy link
Member

@jodastephen jodastephen commented May 15, 2018

This makes HalfUpRounding package scoped, as it should have been
Just use the the methods on Rounding instead

This makes HalfUpRounding package scoped, as it should have been
Just use the the methods on Rounding instead
@jodastephen jodastephen requested a review from cjkent May 15, 2018
@cjkent
cjkent approved these changes May 15, 2018
@cjkent cjkent merged commit 5ec4e08 into master May 15, 2018
15 checks passed
15 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No dependency changes
Details
security/snyk - modules/basics/pom.xml No dependency changes
Details
security/snyk - modules/calc/pom.xml No dependency changes
Details
security/snyk - modules/collect/pom.xml No dependency changes
Details
security/snyk - modules/data/pom.xml No dependency changes
Details
security/snyk - modules/loader/pom.xml No dependency changes
Details
security/snyk - modules/market/pom.xml No dependency changes
Details
security/snyk - modules/math/pom.xml No dependency changes
Details
security/snyk - modules/measure/pom.xml No dependency changes
Details
security/snyk - modules/pom.xml No dependency changes
Details
security/snyk - modules/pricer/pom.xml No dependency changes
Details
security/snyk - modules/product/pom.xml No dependency changes
Details
security/snyk - modules/report/pom.xml No dependency changes
Details
@cjkent cjkent deleted the topic/currency-round branch May 15, 2018
jodastephen added a commit that referenced this pull request May 17, 2018
This makes HalfUpRounding package scoped, as it should have been
Just use the the methods on Rounding instead
@jodastephen jodastephen modified the milestones: v1.8, v2.0 Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants