New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FxTrade interface #1691

Merged
merged 2 commits into from May 17, 2018

Conversation

Projects
None yet
2 participants
@jodastephen
Member

jodastephen commented May 15, 2018

Abstract access to CurrencyPair

Add FxTrade interface
Abstract access to `CurrencyPair`
Add FxTrade interface
Abstract access to `CurrencyPair`
@yukiiwashita

One comment is that a problem occurs if more than one currency pair are involved. For the moment, such products are not in our coverage.

@jodastephen jodastephen merged commit 88b362b into master May 17, 2018

15 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No dependency changes
Details
security/snyk - modules/basics/pom.xml No dependency changes
Details
security/snyk - modules/calc/pom.xml No dependency changes
Details
security/snyk - modules/collect/pom.xml No dependency changes
Details
security/snyk - modules/data/pom.xml No dependency changes
Details
security/snyk - modules/loader/pom.xml No dependency changes
Details
security/snyk - modules/market/pom.xml No dependency changes
Details
security/snyk - modules/math/pom.xml No dependency changes
Details
security/snyk - modules/measure/pom.xml No dependency changes
Details
security/snyk - modules/pom.xml No dependency changes
Details
security/snyk - modules/pricer/pom.xml No dependency changes
Details
security/snyk - modules/product/pom.xml No dependency changes
Details
security/snyk - modules/report/pom.xml No dependency changes
Details

@jodastephen jodastephen deleted the topic/fx-trade branch May 17, 2018

jodastephen added a commit that referenced this pull request May 17, 2018

Add FxTrade interface (#1691)
* Add FxTrade interface

Abstract access to `CurrencyPair`

@jodastephen jodastephen modified the milestones: v1.8, v2.0 Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment