Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FxTrade interface #1691

Merged
merged 2 commits into from May 17, 2018
Merged

Add FxTrade interface #1691

merged 2 commits into from May 17, 2018

Conversation

jodastephen
Copy link
Member

Abstract access to CurrencyPair

Abstract access to `CurrencyPair`
Abstract access to `CurrencyPair`
Copy link
Contributor

@yukiiwashita yukiiwashita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment is that a problem occurs if more than one currency pair are involved. For the moment, such products are not in our coverage.

@jodastephen jodastephen merged commit 88b362b into master May 17, 2018
@jodastephen jodastephen deleted the topic/fx-trade branch May 17, 2018 13:17
jodastephen added a commit that referenced this pull request May 17, 2018
* Add FxTrade interface

Abstract access to `CurrencyPair`
@jodastephen jodastephen modified the milestones: v1.8, v2.0 Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants