Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify FxTrade #1696

Merged
merged 1 commit into from May 21, 2018
Merged

Simplify FxTrade #1696

merged 1 commit into from May 21, 2018

Conversation

@jodastephen
Copy link
Member

@jodastephen jodastephen commented May 21, 2018

Access currency pair via product rather than directly

Access currency pair via product rather than directly
@jodastephen jodastephen force-pushed the topic/fx-trade branch from 3064694 to 55ea4cd May 21, 2018
@jodastephen jodastephen changed the title Topic/fx trade Simplify FxTrade May 21, 2018
@andreiruse andreiruse merged commit a30cb79 into master May 21, 2018
15 checks passed
15 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No dependency changes
Details
security/snyk - modules/basics/pom.xml No dependency changes
Details
security/snyk - modules/calc/pom.xml No dependency changes
Details
security/snyk - modules/collect/pom.xml No dependency changes
Details
security/snyk - modules/data/pom.xml No dependency changes
Details
security/snyk - modules/loader/pom.xml No dependency changes
Details
security/snyk - modules/market/pom.xml No dependency changes
Details
security/snyk - modules/math/pom.xml No dependency changes
Details
security/snyk - modules/measure/pom.xml No dependency changes
Details
security/snyk - modules/pom.xml No dependency changes
Details
security/snyk - modules/pricer/pom.xml No dependency changes
Details
security/snyk - modules/product/pom.xml No dependency changes
Details
security/snyk - modules/report/pom.xml No dependency changes
Details
@andreiruse andreiruse deleted the topic/fx-trade branch May 21, 2018
jodastephen added a commit that referenced this pull request Jun 5, 2018
Access currency pair via product rather than directly
jodastephen added a commit that referenced this pull request Jun 5, 2018
Access currency pair via product rather than directly
@jodastephen jodastephen modified the milestones: v1.8, v2.0 Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants