Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add currency accessors to Product #1697

Merged
merged 1 commit into from May 23, 2018
Merged

Add currency accessors to Product #1697

merged 1 commit into from May 23, 2018

Conversation

@jodastephen
Copy link
Member

@jodastephen jodastephen commented May 21, 2018

Currency is a key aspect of a product and should be easy to access
This change is backwards incompatible for Product implementations
Method on SwapLeg also changed from a poor default to be abstract

Currency is a key aspect of a product and should be easy to access
This change is backwards incompatible for Product implementations
Method on SwapLeg also changed from a poor default to be abstract
@jodastephen jodastephen merged commit 7528b46 into master May 23, 2018
15 checks passed
Loading
@jodastephen jodastephen deleted the topic/extend-product branch May 23, 2018
@jodastephen jodastephen added this to the v1.8 milestone Jun 5, 2018
@jodastephen jodastephen removed this from the v1.8 milestone Jun 5, 2018
@jodastephen jodastephen added this to the v2.0 milestone Jun 5, 2018
@jodastephen jodastephen removed this from the v2.0 milestone Jun 12, 2018
@jodastephen jodastephen added this to the v2.0 milestone Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants