Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add currency accessors to Product #1697

Merged
merged 1 commit into from May 23, 2018

Conversation

Projects
None yet
2 participants
@jodastephen
Copy link
Member

jodastephen commented May 21, 2018

Currency is a key aspect of a product and should be easy to access
This change is backwards incompatible for Product implementations
Method on SwapLeg also changed from a poor default to be abstract

Add currency accessors to Product
Currency is a key aspect of a product and should be easy to access
This change is backwards incompatible for Product implementations
Method on SwapLeg also changed from a poor default to be abstract

@jodastephen jodastephen merged commit 7528b46 into master May 23, 2018

15 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No dependency changes
Details
security/snyk - modules/basics/pom.xml No dependency changes
Details
security/snyk - modules/calc/pom.xml No dependency changes
Details
security/snyk - modules/collect/pom.xml No dependency changes
Details
security/snyk - modules/data/pom.xml No dependency changes
Details
security/snyk - modules/loader/pom.xml No dependency changes
Details
security/snyk - modules/market/pom.xml No dependency changes
Details
security/snyk - modules/math/pom.xml No dependency changes
Details
security/snyk - modules/measure/pom.xml No dependency changes
Details
security/snyk - modules/pom.xml No dependency changes
Details
security/snyk - modules/pricer/pom.xml No dependency changes
Details
security/snyk - modules/product/pom.xml No dependency changes
Details
security/snyk - modules/report/pom.xml No dependency changes
Details

@jodastephen jodastephen deleted the topic/extend-product branch May 23, 2018

@jodastephen jodastephen modified the milestones: v1.8, v2.0 Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.