Provide ability to lookup any index #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance ExtendedEnum to support ability to combine separate enums Add lookup method to Index Ensure that Joda serialization with maps keyed by Index work correctly
brianweller89
approved these changes
May 31, 2018
| * @param alternateNames the map of alternate name to standard name | ||
| * @param externalNames the map of external name groups | ||
| */ | ||
| private CombinedExtendedEnum( |
There was a problem hiding this comment.
These params are screwed up
| DefaultRatesMarketDataLookup test = | ||
| DefaultRatesMarketDataLookup.of(discounts, forwards, ObservableSource.NONE, FxRateLookup.ofRates()); | ||
| String xml = JodaBeanSer.PRETTY.xmlWriter().write(test); | ||
| System.out.println(xml); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance ExtendedEnum to support ability to combine separate enums.
Add lookup method to Index.
Ensure that Joda serialization with maps keyed by Index work correctly.
This will reduce the size of certain pieces of stored data.