Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ability to lookup any index #1708

Merged
merged 2 commits into from Jun 4, 2018
Merged

Provide ability to lookup any index #1708

merged 2 commits into from Jun 4, 2018

Conversation

@jodastephen
Copy link
Member

@jodastephen jodastephen commented May 31, 2018

Enhance ExtendedEnum to support ability to combine separate enums.
Add lookup method to Index.
Ensure that Joda serialization with maps keyed by Index work correctly.

This will reduce the size of certain pieces of stored data.

Enhance ExtendedEnum to support ability to combine separate enums
Add lookup method to Index
Ensure that Joda serialization with maps keyed by Index work correctly
* @param alternateNames the map of alternate name to standard name
* @param externalNames the map of external name groups
*/
private CombinedExtendedEnum(

This comment has been minimized.

@brianweller89

brianweller89 May 31, 2018
Contributor

These params are screwed up

DefaultRatesMarketDataLookup test =
DefaultRatesMarketDataLookup.of(discounts, forwards, ObservableSource.NONE, FxRateLookup.ofRates());
String xml = JodaBeanSer.PRETTY.xmlWriter().write(test);
System.out.println(xml);

This comment has been minimized.

@brianweller89

brianweller89 May 31, 2018
Contributor

println left behind

@jodastephen jodastephen merged commit fcc48dc into master Jun 4, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jodastephen jodastephen deleted the topic/index-lookup branch Jun 4, 2018
@jodastephen jodastephen modified the milestones: v1.8, v2.0 Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants