Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolvable securities #1711

Merged
merged 1 commit into from Jun 6, 2018

Conversation

Projects
None yet
2 participants
@jodastephen
Copy link
Member

jodastephen commented Jun 4, 2018

Provide means to resolve securities more easily
Add ResolvableSecurityTrade implemented by SecurityTrade
Change GenericSecurityTrade to be a SecuritizedProductTrade
Tidy interfaces to avoid unnecessary inheritance
Potential for source incompatibilities if impl security interfaces

@jodastephen jodastephen requested a review from cjkent Jun 4, 2018

Resolvable securities
Provide means to resolve securities more easily
Add `ResolvableSecurityTrade` implemented by `SecurityTrade`
Change `GenericSecurityTrade` to be a `SecuritizedProductTrade`
Tidy interfaces to avoid unnecessary inheritance
Potential for source incompatibilities if impl security interfaces

@jodastephen jodastephen force-pushed the topic/resolve-target branch from 99832c9 to 457067c Jun 5, 2018

@cjkent

cjkent approved these changes Jun 6, 2018

@cjkent cjkent merged commit 7ac1d09 into master Jun 6, 2018

15 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No dependency changes
Details
security/snyk - modules/basics/pom.xml No dependency changes
Details
security/snyk - modules/calc/pom.xml No dependency changes
Details
security/snyk - modules/collect/pom.xml No dependency changes
Details
security/snyk - modules/data/pom.xml No dependency changes
Details
security/snyk - modules/loader/pom.xml No dependency changes
Details
security/snyk - modules/market/pom.xml No dependency changes
Details
security/snyk - modules/math/pom.xml No dependency changes
Details
security/snyk - modules/measure/pom.xml No dependency changes
Details
security/snyk - modules/pom.xml No dependency changes
Details
security/snyk - modules/pricer/pom.xml No dependency changes
Details
security/snyk - modules/product/pom.xml No dependency changes
Details
security/snyk - modules/report/pom.xml No dependency changes
Details

@cjkent cjkent deleted the topic/resolve-target branch Jun 6, 2018

@jodastephen jodastephen added this to the v2.0 milestone Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.