Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FxSingle #1729

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Refactor FxSingle #1729

merged 1 commit into from
Jun 12, 2018

Conversation

jodastephen
Copy link
Member

Support case where the payment date differs between the currencies such as for AED and EGP.
Support old serialized form.

Support case where the payment date differs between the currencies
such as for AED and EGP
Support old serialized form
@@ -158,9 +189,8 @@ public void test_builder_rightOrder() {

public void test_builder_switchOrder() {
FxSingle test = FxSingle.meta().builder()
.set(FxSingle.meta().baseCurrencyAmount(), USD_M1600)
.set(FxSingle.meta().counterCurrencyAmount(), GBP_P1000)
.set(FxSingle.meta().paymentDate(), DATE_2015_06_30)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hasn't changed from before, but I wouldn't mind an explanation of how we end up with the same baseCurrencyAmount when we appear to set it to something different!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The currency pair is GBP/USD, so the facyory method needs to swap these around to get GBP as the base and USD as the counter

@jodastephen jodastephen merged commit 9424c67 into master Jun 12, 2018
@jodastephen jodastephen deleted the topic/fx-single-structure branch June 12, 2018 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants