Refactor FxSingle #1729
Merged
Refactor FxSingle #1729
Conversation
Support case where the payment date differs between the currencies such as for AED and EGP Support old serialized form
| @@ -158,9 +189,8 @@ public void test_builder_rightOrder() { | |||
|
|
|||
| public void test_builder_switchOrder() { | |||
| FxSingle test = FxSingle.meta().builder() | |||
| .set(FxSingle.meta().baseCurrencyAmount(), USD_M1600) | |||
| .set(FxSingle.meta().counterCurrencyAmount(), GBP_P1000) | |||
| .set(FxSingle.meta().paymentDate(), DATE_2015_06_30) | |||
headphonejack
Jun 12, 2018
Contributor
This hasn't changed from before, but I wouldn't mind an explanation of how we end up with the same baseCurrencyAmount when we appear to set it to something different!
This hasn't changed from before, but I wouldn't mind an explanation of how we end up with the same baseCurrencyAmount when we appear to set it to something different!
jodastephen
Jun 12, 2018
Author
Member
The currency pair is GBP/USD, so the facyory method needs to swap these around to get GBP as the base and USD as the counter
The currency pair is GBP/USD, so the facyory method needs to swap these around to get GBP as the base and USD as the counter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Support case where the payment date differs between the currencies such as for AED and EGP.
Support old serialized form.