Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactor FxSingle #1729
Conversation
jodastephen
assigned
jodastephen and
headphonejack
Jun 12, 2018
jodastephen
requested a review
from
headphonejack
Jun 12, 2018
jodastephen
added this to the v2.0 milestone
Jun 12, 2018
| @@ -158,9 +189,8 @@ public void test_builder_rightOrder() { | ||
| public void test_builder_switchOrder() { | ||
| FxSingle test = FxSingle.meta().builder() | ||
| .set(FxSingle.meta().baseCurrencyAmount(), USD_M1600) | ||
| .set(FxSingle.meta().counterCurrencyAmount(), GBP_P1000) | ||
| .set(FxSingle.meta().paymentDate(), DATE_2015_06_30) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
headphonejack
Jun 12, 2018
This hasn't changed from before, but I wouldn't mind an explanation of how we end up with the same baseCurrencyAmount when we appear to set it to something different!
headphonejack
Jun 12, 2018
This hasn't changed from before, but I wouldn't mind an explanation of how we end up with the same baseCurrencyAmount when we appear to set it to something different!
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
jodastephen
Jun 12, 2018
Member
The currency pair is GBP/USD, so the facyory method needs to swap these around to get GBP as the base and USD as the counter
jodastephen
Jun 12, 2018
Member
The currency pair is GBP/USD, so the facyory method needs to swap these around to get GBP as the base and USD as the counter
jodastephen
merged commit 9424c67
into
master
Jun 12, 2018
jodastephen
deleted the
topic/fx-single-structure
branch
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jodastephen commentedJun 12, 2018
Support case where the payment date differs between the currencies such as for AED and EGP.
Support old serialized form.