Add NumberFormatter #1793
Merged
Add NumberFormatter #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thread-safe wrapper around DecimalFormat/NumberFormat ThreadLocal is 2.5x faster than clone() for common cases
cjkent
reviewed
Sep 6, 2018
| * The integer part will be grouped if the flag is set. | ||
| * The decimal part will never be grouped or truncated. | ||
| * The implementation uses English locale data, which uses commas as a separator and a decimal point (dot). | ||
| * Numbers will be rounded using {@link RoundingMode#HALF_EVEN} |
There was a problem hiding this comment.
Why HALF_EVEN and not HALF_UP? HALF_UP is the "standard" rounding mode everyone learns at school. From the Javadocs for HALF_UP
Note that this is the rounding mode commonly taught at school.
There was a problem hiding this comment.
It is what DecimalFormat uses.
There was a problem hiding this comment.
So it does. That surprises me.
cjkent
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread-safe wrapper around
DecimalFormat/NumberFormat.ThreadLocalis 2.5x faster than clone() for common cases.