Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brl conventions #1828

Merged
merged 36 commits into from Nov 9, 2018
Merged

Brl conventions #1828

merged 36 commits into from Nov 9, 2018

Conversation

@r-weeks
Copy link
Contributor

@r-weeks r-weeks commented Oct 17, 2018

Brl Conventions.
Separate branch.

@r-weeks r-weeks requested a review from jodastephen Oct 17, 2018
r-weeks added 2 commits Oct 18, 2018
…um due to the conflict of terminology between rates and simple rates.
jodastephen added 3 commits Nov 2, 2018
Basic style fixes
Minor updates to docs, code layout etc.
Additional smaller fixes
Cache simple fixed rate
FutureValueNotional parameter types
Copy link
Member

@jodastephen jodastephen left a comment

Remaining items are naming issues in FixedNotionalAccrualMethod, FIxedRateCalculation, FutureValueNotional, FixedRateSwapLegConvention

@jodastephen jodastephen merged commit 9aa6184 into master Nov 9, 2018
14 checks passed
@jodastephen jodastephen deleted the brl_conventions branch Nov 9, 2018
@jodastephen jodastephen added this to the v2.2 milestone Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants