Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow double stub with no regular periods #1873

Merged
merged 2 commits into from Jan 22, 2019
Merged

Allow double stub with no regular periods #1873

merged 2 commits into from Jan 22, 2019

Conversation

@jodastephen
Copy link
Member

@jodastephen jodastephen commented Jan 18, 2019

Edge case where the first regular and last regular date are the same
Although odd, there doesn't seem to be a strong case to disallow this

Copy link

@jonfreedman jonfreedman left a comment

As per https://forums.opengamma.com/t/stubconvention-required-for-smart-front-short-final-stub/858/4 I don't think this fully fixes the issue, it may be necessary to change line 686 to

if (!start.isEqual(end)) {
    dates.add(start);
}

jodastephen added 2 commits Jan 21, 2019
Edge case where the first regular and last regular date are the same
Although odd there doesn't seem to be a strong case to disallow this
@jodastephen jodastephen force-pushed the topic/double-stub branch from 7cbc812 to 7a59f26 Jan 21, 2019
cjkent
cjkent approved these changes Jan 22, 2019
@cjkent cjkent merged commit 914c219 into master Jan 22, 2019
30 checks passed
@cjkent cjkent deleted the topic/double-stub branch Jan 22, 2019
@jodastephen jodastephen added this to the v2.2 milestone Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants