Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesSupport more cash settlement methods from FpML #1921
Conversation
jodastephen
assigned
marc-henrard
Mar 19, 2019
jodastephen
requested a review
from
marc-henrard
Mar 19, 2019
marc-henrard
merged commit b7e2d85
into
master
Mar 19, 2019
15 checks passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
security/snyk - examples/pom.xml (OpenGamma)
No new issues
Details
security/snyk - modules/calc/pom.xml (OpenGamma)
No new issues
Details
security/snyk - modules/collect/pom.xml (OpenGamma)
No new issues
Details
security/snyk - modules/data/pom.xml (OpenGamma)
No new issues
Details
security/snyk - modules/loader/pom.xml (OpenGamma)
No new issues
Details
security/snyk - modules/market/pom.xml (OpenGamma)
No new issues
Details
security/snyk - modules/math/pom.xml (OpenGamma)
No new issues
Details
security/snyk - modules/measure/pom.xml (OpenGamma)
No new issues
Details
security/snyk - modules/pom.xml (OpenGamma)
No new issues
Details
security/snyk - modules/product/pom.xml (OpenGamma)
No new issues
Details
security/snyk - modules/report/pom.xml (OpenGamma)
No new issues
Details
security/snyk - pom.xml (OpenGamma)
No new issues
Details
workflow
Workflow: workflow
Details
delete-merged-branch
bot
deleted the
topic/fpml-swaption
branch
Mar 19, 2019
jodastephen
added
the
Type:Enhancement
label
Mar 25, 2019
jodastephen
added this to the v2.3 milestone
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jodastephen commentedMar 19, 2019
FpML parsing is extended to support two more cash settlement methods
cashPriceMethodis merged withcashPriceAlternateMethodcollateralizedCashPriceMethodis connected to new code in StrataFix spelling of
parYieldCurveAdjustedMethodFixes #1903