More lenient schedule generation #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the roll convention is EOM and there is no explicit final stub and the start date is at the end-of-month then the end date is valid if it equals the start date day-of-month This handles 2019-02-28 to 2024-02-28 (normally 2024-02-29) and 2018-04-30 to 2018-10-30 (normally 2018-10-31)
cjkent
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the roll convention is EOM
and there is no explicit final stub
and the start date is at the end-of-month
then the end date is valid if it equals the start date day-of-month
This handles 2019-02-28 to 2024-02-28 (normally 2024-02-29)
and 2018-04-30 to 2018-10-30 (normally 2018-10-31)