Add support for CDS in CSV #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow standard pattern of other asset classes
jodastephen
force-pushed
the
topic/cds-csv
branch
from
b604624
to
d84ca11
Compare
wjnicholson
approved these changes
Apr 25, 2019
| row, PREMIUM_CURRENCY_FIELD, PREMIUM_AMOUNT_FIELD, PREMIUM_DIRECTION_FIELD); | ||
| AdjustableDate date = CsvLoaderUtils.parseAdjustableDate( | ||
| row, PREMIUM_DATE_FIELD, PREMIUM_DATE_CNV_FIELD, PREMIUM_DATE_CAL_FIELD); | ||
| return AdjustablePayment.of(amount, date); |
There was a problem hiding this comment.
Block lambdas back in fashion now? 🤔
There was a problem hiding this comment.
They have occasional uses, and this demonstrates a use where the lambda is void and side-effecting.
modules/loader/src/main/java/com/opengamma/strata/loader/csv/TradeCsvInfoResolver.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: jodastephen <scolebourne@joda.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow standard pattern of other asset classes