Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CDS in CSV #1956

Merged
merged 2 commits into from Apr 25, 2019
Merged

Add support for CDS in CSV #1956

merged 2 commits into from Apr 25, 2019

Conversation

@jodastephen
Copy link
Member

@jodastephen jodastephen commented Apr 25, 2019

Follow standard pattern of other asset classes

Follow standard pattern of other asset classes
@jodastephen jodastephen added this to the v2.3 milestone Apr 25, 2019
Copy link
Member

@wjnicholson wjnicholson left a comment

One JavaDoc

Loading

row, PREMIUM_CURRENCY_FIELD, PREMIUM_AMOUNT_FIELD, PREMIUM_DIRECTION_FIELD);
AdjustableDate date = CsvLoaderUtils.parseAdjustableDate(
row, PREMIUM_DATE_FIELD, PREMIUM_DATE_CNV_FIELD, PREMIUM_DATE_CAL_FIELD);
return AdjustablePayment.of(amount, date);
Copy link
Member

@wjnicholson wjnicholson Apr 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block lambdas back in fashion now? 🤔

Loading

Copy link
Member Author

@jodastephen jodastephen Apr 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They have occasional uses, and this demonstrates a use where the lambda is void and side-effecting.

Loading

Loading
Co-Authored-By: jodastephen <scolebourne@joda.org>
@jodastephen jodastephen merged commit 19ee4f5 into master Apr 25, 2019
15 checks passed
Loading
@delete-merged-branch delete-merged-branch bot deleted the topic/cds-csv branch Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants