Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CDS in CSV #1956

Merged
merged 2 commits into from Apr 25, 2019

Conversation

Projects
None yet
2 participants
@jodastephen
Copy link
Member

commented Apr 25, 2019

Follow standard pattern of other asset classes

Add support for CDS in CSV
Follow standard pattern of other asset classes

@jodastephen jodastephen force-pushed the topic/cds-csv branch from b604624 to d84ca11 Apr 25, 2019

@jodastephen jodastephen added this to the v2.3 milestone Apr 25, 2019

@wjnicholson
Copy link
Member

left a comment

One JavaDoc

row, PREMIUM_CURRENCY_FIELD, PREMIUM_AMOUNT_FIELD, PREMIUM_DIRECTION_FIELD);
AdjustableDate date = CsvLoaderUtils.parseAdjustableDate(
row, PREMIUM_DATE_FIELD, PREMIUM_DATE_CNV_FIELD, PREMIUM_DATE_CAL_FIELD);
return AdjustablePayment.of(amount, date);

This comment has been minimized.

Copy link
@wjnicholson

wjnicholson Apr 25, 2019

Member

Block lambdas back in fashion now? 🤔

This comment has been minimized.

Copy link
@jodastephen

jodastephen Apr 25, 2019

Author Member

They have occasional uses, and this demonstrates a use where the lambda is void and side-effecting.

Show resolved Hide resolved .../src/main/java/com/opengamma/strata/loader/csv/TradeCsvInfoResolver.java Outdated
Fix cut/paste
Co-Authored-By: jodastephen <scolebourne@joda.org>

@jodastephen jodastephen merged commit 19ee4f5 into master Apr 25, 2019

15 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - examples/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/calc/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/collect/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/data/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/loader/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/market/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/math/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/measure/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/product/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/report/pom.xml (OpenGamma) No new issues
Details
security/snyk - pom.xml (OpenGamma) No new issues
Details
workflow Workflow: workflow
Details

@delete-merged-branch delete-merged-branch bot deleted the topic/cds-csv branch Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.