Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CSV parsing #1981

Merged
merged 1 commit into from May 28, 2019

Conversation

Projects
None yet
2 participants
@jodastephen
Copy link
Member

commented May 24, 2019

Change algorithm to better match other systems and be more lenient.
Difference only noticeable for inputs that are essentially invalid.

New algorithm proceeds character by character. When quoted section is complete, everything is added verbatim until the delimiter. Thus "aaa"bbb, becomes aaabbb.

Refactor CSV parsing
Change algorithm to better match other systems and be more lenient
Difference only noticable for inputs that are essentially invalid
New algorithm proceeds character by character. When quoted section is
complete, everything is added verbatim until the delimiter
Thus "aaa"bbb, becomes aaabbb
@cjkent

cjkent approved these changes May 28, 2019

@cjkent cjkent merged commit ff26b86 into master May 28, 2019

15 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - examples/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/calc/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/collect/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/data/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/loader/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/market/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/math/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/measure/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/product/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/report/pom.xml (OpenGamma) No new issues
Details
security/snyk - pom.xml (OpenGamma) No new issues
Details
workflow Workflow: workflow
Details

@delete-merged-branch delete-merged-branch bot deleted the topic/csv-match branch May 28, 2019

@jodastephen jodastephen added this to the v2.4 milestone May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.