Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CSV parsing #1981

Merged
merged 1 commit into from May 28, 2019
Merged

Refactor CSV parsing #1981

merged 1 commit into from May 28, 2019

Conversation

@jodastephen
Copy link
Member

@jodastephen jodastephen commented May 24, 2019

Change algorithm to better match other systems and be more lenient.
Difference only noticeable for inputs that are essentially invalid.

New algorithm proceeds character by character. When quoted section is complete, everything is added verbatim until the delimiter. Thus "aaa"bbb, becomes aaabbb.

Change algorithm to better match other systems and be more lenient
Difference only noticable for inputs that are essentially invalid
New algorithm proceeds character by character. When quoted section is
complete, everything is added verbatim until the delimiter
Thus "aaa"bbb, becomes aaabbb
cjkent
cjkent approved these changes May 28, 2019
@cjkent cjkent merged commit ff26b86 into master May 28, 2019
15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the topic/csv-match branch May 28, 2019
@jodastephen jodastephen added this to the v2.4 milestone May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants