Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register AttributeType instances #2044

Merged
merged 1 commit into from Jul 31, 2019

Conversation

@jodastephen
Copy link
Member

commented Jul 30, 2019

Store data as strings where possible to aid distributed serialization

Register AttributeType instances
Store data as strings where possible to aid distributed serialization

@jodastephen jodastephen merged commit 5b624b7 into master Jul 31, 2019

13 of 14 checks passed

auto-merge Not merging
Details
build Workflow: build
Details
security/snyk - examples/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/calc/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/collect/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/data/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/loader/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/market/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/math/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/measure/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/product/pom.xml (OpenGamma) No new issues
Details
security/snyk - modules/report/pom.xml (OpenGamma) No new issues
Details
security/snyk - pom.xml (OpenGamma) No new issues
Details

@delete-merged-branch delete-merged-branch bot deleted the topic/attribute-type branch Jul 31, 2019

@jodastephen jodastephen added this to the v2.6 milestone Aug 1, 2019

@jodastephen

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

The impact of this change is that typed attributes are stored as strings. This is visible in the JSON/XML/Binary serialized format, as the Java type of each attribute value is no longer sent. This should be a Good Thing, as it makes the serialized format smaller, and allows a different Java class to be used for the attribute value at each end of the network connection. Most users should not see any incompatibility in code, but it is possible that it might be seen if the serialized format is used in unusual ways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.