Add Black Vega support to FX Option Products#2292
Merged
ChristianOG merged 8 commits intomainfrom Feb 23, 2021
Merged
Conversation
Added Black vega calculation to FxVanillaOption. Added Black vega calculation to FxSingleBarrierOption. Added FxCalculationUtils helper functions to fxopt package (currently in Granite, to be removed forthwith). Changed Bachelier Vega calculation for swaption to conventional vega calculation (without rescaling); removed adjustVega() function. Removed comment on BACHELIER_VEGA indicating that sensitivity is multiplied by volatility.
…Bachelier vega calc (no longer rescaling by vol).
edb360e to
d7f9aef
Compare
jodastephen
approved these changes
Feb 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added VEGA_MARKET_QUOTE_BUCKETED to Measures.
Removed VEGA_BACHELIER Measure (subsumed by above).
Added Black vega calculation to FxVanillaOption.
Added Black vega calculation to FxSingleBarrierOption.
Added FxCalculationUtils helper functions to fxopt package (currently in Granite, to be removed forthwith).
Changed Bachelier Vega calculation for swaption to conventional vega calculation (without rescaling); removed adjustVega() function.
Removed comment on BACHELIER_VEGA indicating that sensitivity is multiplied by volatility.