Skip to content

Add Cap/Floor parsing and related methods. #2342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2021

Conversation

santorog
Copy link
Contributor

@santorog santorog commented Aug 9, 2021

Adding the CapFloor enum in strata, mirroring the BuySell enum.

Also adding some parsing utilities and CSV headers.

@santorog santorog requested a review from jodastephen August 9, 2021 17:35
Copy link
Contributor

@benhamilton-brown benhamilton-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Might be worth finalising with Brian on header columns though, as he's trying to minimise the amount of new fields we have.

@santorog santorog merged commit 8526254 into main Aug 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the topic/add-cap-floor-parsing-methods-and-related-fields branch August 10, 2021 08:21
@jodastephen jodastephen added this to the v2.11 milestone Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants