Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance failure exceptions #2449

Merged
merged 6 commits into from
May 10, 2022
Merged

Enhance failure exceptions #2449

merged 6 commits into from
May 10, 2022

Conversation

jodastephen
Copy link
Member

  • Ensure that FailureItem captures underlying failures
  • This avoids losing failure information within wrapped exceptions

@jodastephen
Enhance failure exceptions
de22ae9 
* Ensure that `FailureItem` captures underlying failures
* This avoids losing failure information within wrapped exceptions
@jodastephen @anand-uk
Update modules/collect/src/main/java/com/opengamma/strata/collect/Mes…
336c9c8 
…sages.java

Co-authored-by: Anand <49917470+anand-uk@users.noreply.github.com>
@jodastephen jodastephen requested a review from anand-uk May 9, 2022 16:28
anand-uk
anand-uk approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@anand-uk anand-uk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, the failure attributes might get overridden when combining two or more failures items. This can be addressed in the subsequent PRs if required.

@jodastephen jodastephen requested review from anand-uk and removed request for ivayloVarbanov May 10, 2022 09:47
@jodastephen jodastephen added this to the v2.12 milestone May 10, 2022
@jodastephen jodastephen added the auto-merge Merge when build finishes label May 10, 2022
@mergify mergify bot merged commit eb83131 into main May 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the topic/failures2 branch May 10, 2022 10:31
@jodastephen jodastephen removed the auto-merge Merge when build finishes label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anand-uk anand-uk anand-uk approved these changes

Assignees
No one assigned
Labels
Type:Enhancement
Projects
None yet
Milestone
v2.12
Development

Successfully merging this pull request may close these issues.
2 participants
@jodastephen @anand-uk