Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance parse exceptions #2456

Merged
merged 2 commits into from
May 10, 2022
Merged

Enhance parse exceptions #2456

merged 2 commits into from
May 10, 2022

Conversation

jodastephen
Copy link
Member

  • Use ParseFailureException
  • Capture more detail on failures

* Use ParseFailureException
* Capture more detail on failures
@jodastephen jodastephen requested a review from anand-uk May 10, 2022 11:28
Copy link
Contributor

@anand-uk anand-uk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modules/loader/src/main/java/com/opengamma/strata/loader/fpml/FpmlDocument.java
In the above class, the docs for the public methods needs updating ... either throws FpmlParseException or ParseFailureException

@jodastephen jodastephen added Type:Enhancement auto-merge Merge when build finishes labels May 10, 2022
@jodastephen jodastephen requested a review from anand-uk May 10, 2022 14:37
@mergify mergify bot merged commit 84bffd1 into main May 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the topic/failures3 branch May 10, 2022 15:15
@jodastephen jodastephen removed the auto-merge Merge when build finishes label May 10, 2022
@jodastephen jodastephen added this to the v2.12 milestone May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants