New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added karatsuba multiplication in C++ #3920

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Aftaab99
Copy link

Aftaab99 commented Jan 11, 2019

Changes:
Added Karatsuba multiplication of n-bit integers in C++

Aftaab99 added some commits Jan 11, 2019

using std::string;
using std::cout;
using std::max;
using std::endl;

This comment has been minimized.

@arnavb

arnavb Jan 11, 2019

Member

While this isn't really bad, our codebase uses std:: everywhere. For the sake of consistency and as our style guide says, please follow this rule. Also, use \n instead of endl.

Fixed coding style
Removed using directive. Replaced endl with '\n'.
@arnavb

arnavb approved these changes Jan 11, 2019

Copy link
Member

arnavb left a comment

In your final output statements, add spaces around <<. You should be good to go otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment