New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create 3glasses hmd driver #154

Merged
merged 2 commits into from Jul 27, 2018

Conversation

Projects
None yet
2 participants
@Douglas-3Glasses
Contributor

Douglas-3Glasses commented Jun 14, 2018

Create 3Glasses driver to support 3Glasses D3 HMD

@TheOnlyJoey

This comment has been minimized.

Show comment
Hide comment
@TheOnlyJoey

TheOnlyJoey Jun 14, 2018

Member

Thanks, the headsets also just arrived, will do some initial testing this evening.

Member

TheOnlyJoey commented Jun 14, 2018

Thanks, the headsets also just arrived, will do some initial testing this evening.

@Douglas-3Glasses

This comment has been minimized.

Show comment
Hide comment
@Douglas-3Glasses

Douglas-3Glasses Jul 11, 2018

Contributor

Hello Joey, we has found the distortion coefficient, please update to source when you merge to master, replace src/drv_3glasses/xgvr.c line134 to "ohmd_set_universal_distortion_k(&(priv->device.properties), 0.75239515, -0.84751135, 0.42455423, 0.66200626); " thank you

Contributor

Douglas-3Glasses commented Jul 11, 2018

Hello Joey, we has found the distortion coefficient, please update to source when you merge to master, replace src/drv_3glasses/xgvr.c line134 to "ohmd_set_universal_distortion_k(&(priv->device.properties), 0.75239515, -0.84751135, 0.42455423, 0.66200626); " thank you

@TheOnlyJoey

This comment has been minimized.

Show comment
Hide comment
@TheOnlyJoey

TheOnlyJoey Jul 11, 2018

Member

Perfect, could you update the pull request? if you push to the branch that you have pull requested initially it will get added to this one.

I will go over the review this evening again and test with the headset.

Member

TheOnlyJoey commented Jul 11, 2018

Perfect, could you update the pull request? if you push to the branch that you have pull requested initially it will get added to this one.

I will go over the review this evening again and test with the headset.

@Douglas-3Glasses

This comment has been minimized.

Show comment
Hide comment
@Douglas-3Glasses

Douglas-3Glasses Jul 12, 2018

Contributor

ok, i have update the pull request, you can merge and test it

Contributor

Douglas-3Glasses commented Jul 12, 2018

ok, i have update the pull request, you can merge and test it

@TheOnlyJoey

This comment has been minimized.

Show comment
Hide comment
@TheOnlyJoey

TheOnlyJoey Jul 18, 2018

Member

It seems that the separation between eyes is not really correct yet, currently the horizontal distance its 63mm between the 2 lenses, is this correct?

Member

TheOnlyJoey commented Jul 18, 2018

It seems that the separation between eyes is not really correct yet, currently the horizontal distance its 63mm between the 2 lenses, is this correct?

@TheOnlyJoey

This comment has been minimized.

Show comment
Hide comment
@TheOnlyJoey

TheOnlyJoey Jul 27, 2018

Member

Looks correct! tested and works well, will pull it into master and do some small touch ups later.
Thanks for 3GLasses for providing the driver themselves. D3 is a solid device!

Member

TheOnlyJoey commented Jul 27, 2018

Looks correct! tested and works well, will pull it into master and do some small touch ups later.
Thanks for 3GLasses for providing the driver themselves. D3 is a solid device!

@TheOnlyJoey TheOnlyJoey merged commit 5ac4dc1 into OpenHMD:master Jul 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment