New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export CMake target #166

Merged
merged 10 commits into from Sep 8, 2018

Conversation

Projects
None yet
2 participants
@magestik
Contributor

magestik commented Aug 30, 2018

I updated the minimum CMake version to 3.1 (aka "modern CMake") in order to export the OpenHMD target with the correct (transitive) dependencies. I did some other minor changes like changing the case of some function calls (everything is lower-case now).

@TheOnlyJoey

This comment has been minimized.

Show comment
Hide comment
@TheOnlyJoey

TheOnlyJoey Sep 6, 2018

Member

So giving my 2 cents on this.
I personally enjoy building shared and static at the same time, since I use them both a the same time, and my pipeline works well with what we have now.
If others prefer the new method please let me know, I will merge on their behalf then :)

Member

TheOnlyJoey commented Sep 6, 2018

So giving my 2 cents on this.
I personally enjoy building shared and static at the same time, since I use them both a the same time, and my pipeline works well with what we have now.
If others prefer the new method please let me know, I will merge on their behalf then :)

@magestik

This comment has been minimized.

Show comment
Hide comment
@magestik

magestik Sep 7, 2018

Contributor

Thank you for your feedback.

Maybe I can add an option to allow building both libs ? Something like BUILD_BOTH_STATIC_SHARED_LIBS (named after the default BUILD_SHARED_LIBS variable)

This would allow us to build OpenHMD :

  • as a static library (default)
  • as a shared library (BUILD_SHARED_LIBS=ON)
  • in both version (BUILD_BOTH_STATIC_SHARED_LIBS=ON)
Contributor

magestik commented Sep 7, 2018

Thank you for your feedback.

Maybe I can add an option to allow building both libs ? Something like BUILD_BOTH_STATIC_SHARED_LIBS (named after the default BUILD_SHARED_LIBS variable)

This would allow us to build OpenHMD :

  • as a static library (default)
  • as a shared library (BUILD_SHARED_LIBS=ON)
  • in both version (BUILD_BOTH_STATIC_SHARED_LIBS=ON)
@TheOnlyJoey

This comment has been minimized.

Show comment
Hide comment
@TheOnlyJoey

TheOnlyJoey Sep 7, 2018

Member
Member

TheOnlyJoey commented Sep 7, 2018

@magestik

This comment has been minimized.

Show comment
Hide comment
@magestik

magestik Sep 7, 2018

Contributor

Done. I can probably clean it a bit to remove redundant code.

Contributor

magestik commented Sep 7, 2018

Done. I can probably clean it a bit to remove redundant code.

@magestik

This comment has been minimized.

Show comment
Hide comment
@magestik

magestik Sep 8, 2018

Contributor

I fixed some issues when compiling with MSVC (not related to previous changes). Seems all good now.

Contributor

magestik commented Sep 8, 2018

I fixed some issues when compiling with MSVC (not related to previous changes). Seems all good now.

@TheOnlyJoey

This comment has been minimized.

Show comment
Hide comment
@TheOnlyJoey

TheOnlyJoey Sep 8, 2018

Member

Normally would rather have them in a separate PR but since these are all CMake optimizations, works for me.

Member

TheOnlyJoey commented Sep 8, 2018

Normally would rather have them in a separate PR but since these are all CMake optimizations, works for me.

@TheOnlyJoey TheOnlyJoey merged commit 1916d17 into OpenHMD:master Sep 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment