Skip to content

fix: replace colons in command filenames for Windows compatibility#317

Open
jamiechicago312 wants to merge 2 commits into
OpenHands:mainfrom
jamiechicago312:fix/230-colon-filename-windows
Open

fix: replace colons in command filenames for Windows compatibility#317
jamiechicago312 wants to merge 2 commits into
OpenHands:mainfrom
jamiechicago312:fix/230-colon-filename-windows

Conversation

@jamiechicago312

Copy link
Copy Markdown
Member

Fixes #230

Problem

Colons in filenames (e.g., automation:create.md) break git sync on Windows.

Solution

  1. Replace : with - in scripts/sync_extensions.py
  2. Rename 8 existing colon-named files

Created by AI agent on behalf of @jamiechicago312

Replace colons with dashes in generated command filenames to avoid
Windows filesystem restrictions (colon is reserved character).

Also rename existing colon-named files:
- automation:create.md -> automation-create.md
- slack-monitor:poll.md -> slack-monitor-poll.md
- github-monitor:poll.md -> github-monitor-poll.md
- And 5 more similar renames

Closes OpenHands#230
@github-actions github-actions Bot added the type: fix A bug fix label Jun 8, 2026
Co-authored-by: openhands <openhands@all-hands.dev>

@jamiechicago312 jamiechicago312 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. Replacing : with - in generated command filenames keeps the change small and easy to maintain, while the command trigger itself still stays unchanged. I pushed one follow-up commit (84a2f6c) that adds a focused regression test so this Windows-compatibility behavior stays covered going forward.

Validation I ran:

  • .venv/bin/python -m pytest -q tests/test_sync_extensions.py
  • .venv/bin/python scripts/sync_extensions.py --check

This review was created by an AI agent (OpenHands) on behalf of the user.

@jpelletier1

Copy link
Copy Markdown
Contributor

@malhotra5 I think there are other examples where colons are used in SKILLS related to pre-built automations, such as github-repo-monitor. I think we need to make sure this is fixed across the pre-built extensions.

@malhotra5 malhotra5 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malhotra5

malhotra5 commented Jun 9, 2026

Copy link
Copy Markdown
Member

Also just to note, in the latest versions of agent canvas we no longer git clone the extensions repo. Rather we bundle the npm package for the extensions repo directly into the agent canvas. Nevertheless this seems like a good fix to get in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Colon : in file names breaks git sync on Windows

4 participants