Fix evaluation workflow failure when release branches are deleted #1310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a release is published (e.g.,
v1.4.0), the evaluation workflow fails with:This happens because:
target_commitishcontains the branch name (e.g.,rel-1.4.0), not a commit SHASolution
Convert the branch name to a commit SHA using
git rev-parsebefore passing it to the evaluation workflow. This ensures the reference remains valid even after branch deletion.The fix includes a fallback chain:
target_commitish(the branch name) to its SHAtarget_commitishvalueThis approach matches the pattern already used for manual workflow dispatch (line 137).
Testing
target_commitishfor recent releases contains branch names:rel-1.4.0rel-1.3.0rel-1.2.0git rev-parsewhich is already available (repository is checked out at line 73)Impact
@simonrosenberg can click here to continue refining the PR
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:8802b90-pythonRun
All tags pushed for this build
About Multi-Architecture Support
8802b90-python) is a multi-arch manifest supporting both amd64 and arm648802b90-python-amd64) are also available if needed