Fix conversation run flow in example app #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add run() calls after sendMessage() to start agent execution - Implement real-time WebSocket event handling with callbacks - Add visual status indicators with icons for agent states - Add manual Run/Pause buttons for conversation control - Implement periodic status refresh for running conversations - Improve error handling and logging for WebSocket connections - Fix conversation lifecycle: sendMessage() → run() → WebSocket events Resolves issue where conversations were created but agents never executed. The run() method is non-blocking and starts agent processing asynchronously, with real-time updates delivered via WebSocket events. Co-authored-by: openhands <openhands@all-hands.dev>
- Replace Node.js 'ws' import with universal WebSocket implementation - Use native browser WebSocket when available, fallback to 'ws' in Node.js - Handle different event APIs: browser (onmessage) vs Node.js (.on()) - Maintain backward compatibility for Node.js environments - Fix 'ws does not work in the browser' error in example app This allows the SDK to work in both browser and Node.js environments without requiring separate builds or polyfills. Co-authored-by: openhands <openhands@all-hands.dev>
- Replace require() inside function with top-level require - Add eslint-disable comment for necessary require statement - Maintain browser/Node.js compatibility while passing linter Fixes failing CI linter check in GitHub Actions. Co-authored-by: openhands <openhands@all-hands.dev>
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
Apply Prettier formatting to match project standards. Fixes failing CI formatting check in GitHub Actions. Co-authored-by: openhands <openhands@all-hands.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The example app was creating conversations but they weren't actually running. When users sent messages, the conversations would be created and messages would be sent, but the agents never started processing them. This was because the app was missing the crucial
run()call aftersendMessage().Root Cause
The OpenHands Agent Server TypeScript SDK follows this pattern:
sendMessage()- Sends a message withrun: false(doesn't start agent)run()- Starts the agent to process messages (non-blocking)The example app was only doing step 1, so agents never started processing.
Solution
Core Fixes
run()calls: After everysendMessage(), callconversation.run()to start agent executionUI Improvements
Technical Details
run()is non-blocking - it starts agent execution and returns immediatelyTesting
Files Changed
example/src/components/ConversationManager.tsx- Main conversation management componentBreaking Changes
None - this is a bug fix that makes the example app work as intended.
Related Issues
Fixes the issue where conversations were created but agents never executed, making the example app actually functional for demonstrating the SDK capabilities.
@rbren can click here to continue refining the PR