Add optional ref option to RemoteWorkspace.gitChanges/gitDiff#146
Merged
Conversation
Mirrors the new optional 'ref' query parameter on the agent server's
/api/git/changes and /api/git/diff endpoints. Pass { ref: 'HEAD' } to
get 'git status'-style diffs (working tree + index vs the latest
commit) instead of the default upstream/default-branch comparison:
await ws.gitChanges('/repo', { ref: 'HEAD' });
await ws.gitDiff('/repo/file.ts', { ref: 'HEAD' });
Calls without options are unchanged on the wire (no 'ref' param sent),
so this is fully backwards compatible.
The new GitQueryOptions type is added to workspace/base.ts, exported
from the package root, and threaded through IWorkspace, RemoteWorkspace
and LocalWorkspace. Unit tests assert the query-param wire format
(present when supplied, absent by default) on both endpoints, and the
git-query integration test now also exercises ref='HEAD' end-to-end.
Co-authored-by: openhands <openhands@all-hands.dev>
Member
Author
|
@OpenHands fix the failing tests |
|
I'm on it! rbren can track my progress at all-hands.dev |
Co-authored-by: openhands <openhands@all-hands.dev>
|
Final summary of new work since the last update:
What changed:
Conciseness check:
Verification completed:
Final git update:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the new optional 'ref' query parameter on the agent server's /api/git/changes and /api/git/diff endpoints. Pass { ref: 'HEAD' } to get 'git status'-style diffs (working tree + index vs the latest commit) instead of the default upstream/default-branch comparison:
await ws.gitChanges('/repo', { ref: 'HEAD' });
await ws.gitDiff('/repo/file.ts', { ref: 'HEAD' });
Calls without options are unchanged on the wire (no 'ref' param sent), so this is fully backwards compatible.
The new GitQueryOptions type is added to workspace/base.ts, exported from the package root, and threaded through IWorkspace, RemoteWorkspace and LocalWorkspace. Unit tests assert the query-param wire format (present when supplied, absent by default) on both endpoints, and the git-query integration test now also exercises ref='HEAD' end-to-end.
Why
Summary
Issue Number
How to Test
Video/Screenshots
Type
Notes