Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More gradual fmt conversion #2649

Merged
merged 2 commits into from Jul 30, 2020
Merged

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented Jul 28, 2020

Another step toward switching to std::format notation.

The basic strategy is to make sure that all the classes that have
errorf (etc) methods using printf notation will also have errorfmt
(etc) methods using std::format notation. These will coexist for a
while to let people switch, before the printf ones will be marked
deprecated and then eventually removed.

In some cases where the methods aren't really part of the public
API, but only are used by interns, we are already skipping to the
deprecation marking or just changing them completely.

Signed-off-by: Larry Gritz lg@larrygritz.com

Another step toward switching to std::format notation.

The basic strategy is to make sure that all the classes that have
errorf (etc) methods using printf notation will also have errorfmt
(etc) methods using std::format notation. These will coexist for a
while to let people switch, before the printf ones will be marked
deprecated and then eventually removed.

In some cases where the methods aren't really part of the public
API, but only are used internally, we are already skipping to the
deprecation marking.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
Copy link
Contributor

@fpsunflower fpsunflower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small suggestion about renaming a method.

src/libutil/typedesc.cpp Outdated Show resolved Hide resolved
Signed-off-by: Larry Gritz <lg@larrygritz.com>
Copy link
Contributor

@fpsunflower fpsunflower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lgritz lgritz merged commit 3082bd7 into AcademySoftwareFoundation:master Jul 30, 2020
@lgritz lgritz deleted the lg-fmt branch July 31, 2020 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants