New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Pulseaudio to 10.0 #2370

Merged
merged 1 commit into from Apr 23, 2017

Conversation

Projects
None yet
2 participants
@alarcher
Contributor

alarcher commented Aug 27, 2016

@@ -0,0 +1 @@
Basic Solaris User:solaris:cmd:RO::/usr/bin/pulseaudio:privs=proc_priocntl,file_dac_read

This comment has been minimized.

@pyhalov

pyhalov Aug 29, 2016

Contributor

Why is it needed? Does pulseaudio drop them after opening devices?

This comment has been minimized.

@pyhalov

pyhalov Aug 29, 2016

Contributor

I mean, audio devices are usually owned by Console User

This comment has been minimized.

@alarcher

alarcher Aug 29, 2016

Contributor

Running with ppriv throws missing privileges when auditing in non --system mode.

This comment has been minimized.

@pyhalov

pyhalov Aug 29, 2016

Contributor

What files does it try to read? Can we drop privileges after startup? How does it work on Linux?

This comment has been minimized.

@alarcher

alarcher Aug 29, 2016

Contributor

On Linux it uses capabilities to access what it should and raise the priority within the range assigned in the system configuration but beyond its original priority.
On Solaris it is conservative, without the privilege the process can only lower its priority.

This comment has been minimized.

@pyhalov

pyhalov Aug 29, 2016

Contributor

This means, it can read my /etc/shadow in any given time... Can we somehow alleviate this issue? Even setuid application looks more sane :)

This comment has been minimized.

@alarcher

alarcher Aug 29, 2016

Contributor

OK I did not answer your question actually.
I see privilege warnings requiring file_dac_read to start pulseaudio in user-mode, this is not related to the priority.
If you do not see it and everything goes fine for you I will just assume that my machine is cursed.

@alarcher alarcher force-pushed the alarcher:pulseaudio8 branch from 5616558 to 0506745 Aug 29, 2016

link path=etc/bash_completion.d/parecord target=pulseaudio
link path=etc/bash_completion.d/pasuspender target=pulseaudio
file path=etc/bash_completion.d/pulseaudio
file files/pulse_exec_attr path=etc/security/pulseaudio

This comment has been minimized.

@pyhalov

pyhalov Aug 30, 2016

Contributor

/etc/security/exec_attr.d/pulseaudio... And still it doesn't work

This comment has been minimized.

@pyhalov

pyhalov Aug 30, 2016

Contributor

Another issue is that pulseaudio should be run with pfexec after this. Also it seems proc_prioup is missing.

@alarcher alarcher added the needs_work label Sep 7, 2016

@alarcher alarcher force-pushed the alarcher:pulseaudio8 branch from 0506745 to 8252d94 Oct 8, 2016

@alarcher alarcher changed the title from Bump Pulseaudio to 8.0 to Bump Pulseaudio to 9.0 Oct 8, 2016

@alarcher alarcher force-pushed the alarcher:pulseaudio8 branch from 8252d94 to b59eda0 Mar 3, 2017

@alarcher alarcher force-pushed the alarcher:pulseaudio8 branch from b59eda0 to f782773 Apr 20, 2017

@alarcher alarcher changed the title from Bump Pulseaudio to 9.0 to Bump Pulseaudio to 10.0 Apr 20, 2017

@alarcher alarcher force-pushed the alarcher:pulseaudio8 branch from f782773 to 18e00ed Apr 21, 2017

@alarcher

This comment has been minimized.

Contributor

alarcher commented Apr 21, 2017

Let us drop the privilege thing for now.
Ready for merge if you are happy with testing.

@@ -1,225 +1,6 @@
--- pulseaudio-6.0/src/modules/oss/module-oss.c.~1~ 2015-02-12 17:10:35.000000000 +0300

This comment has been minimized.

@pyhalov

pyhalov Apr 22, 2017

Contributor

Why do you remove source_get_volume ?

This comment has been minimized.

@pyhalov

pyhalov Apr 22, 2017

Contributor

Strange, but it seems to be working :)

This comment has been minimized.

@pyhalov

pyhalov Apr 22, 2017

Contributor

But I can't control line-out with this pulseaudio version, only master volume level....

This comment has been minimized.

@alarcher

alarcher Apr 22, 2017

Contributor

I have not modified oss4.patch, I do not understand the question?

This comment has been minimized.

@pyhalov

pyhalov Apr 22, 2017

Contributor

You have not modified oss4 patch comparing to what? The diff clearly shows changes.

This comment has been minimized.

@alarcher

alarcher Apr 22, 2017

Contributor

Right, I rebased on oi/hipster before working on the component, not sure what happened.

This comment has been minimized.

@pyhalov

pyhalov Apr 22, 2017

Contributor

please, add old patch back :)

This comment has been minimized.

@alarcher

alarcher Apr 22, 2017

Contributor

I am already on it but it requires some porting.

This comment has been minimized.

@alarcher

alarcher Apr 22, 2017

Contributor

No I just screwed up with the patch, should be back.

This comment has been minimized.

@pyhalov

pyhalov Apr 23, 2017

Contributor

Looks fine, I'd like to test it on VM where I tested my last pulseaudio changes

@alarcher alarcher force-pushed the alarcher:pulseaudio8 branch from 18e00ed to c47152b Apr 22, 2017

@@ -0,0 +1,12 @@
--- pulseaudio-10.0/src/daemon/default.pa.in.orig 2017-04-22 18:41:17.928890906 +0200

This comment has been minimized.

@pyhalov

pyhalov Apr 22, 2017

Contributor

why this change is necessary?

This comment has been minimized.

@pyhalov

pyhalov Apr 23, 2017

Contributor

OK, found that it's necessary

@pyhalov pyhalov removed the review needed label Apr 23, 2017

@pyhalov

This comment has been minimized.

Contributor

pyhalov commented Apr 23, 2017

It seems I'm ready to merge it, but I have one question.
Have you checked that all dependent packages build with it ?
For me pkg finds the following list:

pkg:/audio/sox
pkg:/gnome/media/gnome-media
pkg:/library/audio/gstreamer/plugin/good
pkg:/library/audio/gstreamer1/plugin/good
pkg:/library/audio/libmikmod
pkg:/library/desktop/gtk-vnc
pkg:/library/desktop/mate/libmatemixer
pkg:/library/desktop/ptlib
pkg:/library/desktop/xdg/libcanberra
pkg:/library/qt4
pkg:/library/qt5
pkg:/media/cdrtools
@pyhalov

This comment has been minimized.

Contributor

pyhalov commented Apr 23, 2017

@@ -0,0 +1 @@
Basic Solaris User:solaris:cmd:RO::/usr/bin/pulseaudio:privs=proc_priocntl,proc_prioup

This comment has been minimized.

@pyhalov

pyhalov Apr 23, 2017

Contributor

It seems it can be dropped

This comment has been minimized.

@alarcher

alarcher Apr 23, 2017

Contributor

Done.

@alarcher alarcher force-pushed the alarcher:pulseaudio8 branch from c47152b to 420e2d4 Apr 23, 2017

@pyhalov

This comment has been minimized.

Contributor

pyhalov commented Apr 23, 2017

tested rebuilding of dependent packages

@pyhalov pyhalov merged commit 65218b8 into OpenIndiana:oi/hipster Apr 23, 2017

@alarcher alarcher deleted the alarcher:pulseaudio8 branch Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment