Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd ck 0.5.2 #2737
Add ck 0.5.2 #2737
Conversation
|
|
||
| include ../../../make-rules/shared-macros.mk | ||
|
|
||
| COMPONENT_NAME= ck |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alarcher
Jan 19, 2017
Author
Contributor
I switched to tabs to conform with most Makefiles... shoud I use spaces instead?
This comment has been minimized.
This comment has been minimized.
pyhalov
Jan 19, 2017
Contributor
I don't know, perhaps, wrong tab count, but usually it looks better on github
| include $(WS_MAKE_RULES)/ips.mk | ||
|
|
||
| USRINCDIR.32=$(USRINCDIR) | ||
| USRINCDIR.64=$(USRINCDIR)/$(MACH64) |
This comment has been minimized.
This comment has been minimized.
pyhalov
Jan 19, 2017
Contributor
Don't do it... We don't ship /usr/include/$(MACH64).
Possible sollutions:
- /usr/lib/ck/include, /usr/lib/$(MACH64)/include for platform-dependent headers (with corresponding pkgconfig patches);
- deliver /usr/include/header-32/64.h and generate /usr/include/header.h , which includes necessary headers - like it's done in python (it would be good to have only one such header with platform-specific definitions);
- patch headers as needed (perhaps, even post-configure, like openssl does).
This comment has been minimized.
This comment has been minimized.
alarcher
Jan 19, 2017
Author
Contributor
FYI Circonus/OmniOS does like this and /usr/include/amd64 already exists for sys.
Which option do you prefer?
This comment has been minimized.
This comment has been minimized.
pyhalov
Jan 19, 2017
Contributor
Does all headers really differ? If only several, we could extract these definitions in /usr/include/header-$(BITS).h. If all, perhaps it's not the best option.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pyhalov
Jan 19, 2017
Contributor
seems better, don't forget to remove unnecessary definitions from Makefile
| install: $(INSTALL_32_and_64) | ||
|
|
||
| # Tests are not supported out-of-source for now | ||
| test: $(TEST_32_and_64) |
This comment has been minimized.
This comment has been minimized.
pyhalov
Jan 19, 2017
Contributor
Will something like in postgresql work? I mean clone or copy source to build dir in pre-configure hook and use CONFIGURE_SCRIPT=$(@d)/configure.
| file path=usr/lib/$(MACH64)/libck.so.$(COMPONENT_VERSION) | ||
| link path=usr/lib/$(MACH64)/libck.so.0 target=libck.so.$(COMPONENT_VERSION) | ||
| file path=usr/lib/$(MACH64)/pkgconfig/ck.pc | ||
| file path=usr/lib/libck.a |
This comment has been minimized.
This comment has been minimized.
| file path=usr/lib/libck.so.$(COMPONENT_VERSION) | ||
| link path=usr/lib/libck.so.0 target=libck.so.$(COMPONENT_VERSION) | ||
| file path=usr/lib/pkgconfig/ck.pc | ||
| file path=usr/share/man/man3/CK_ARRAY_FOREACH.3.gz |
This comment has been minimized.
This comment has been minimized.
pyhalov
Jan 19, 2017
Contributor
Does illumos man understand compressed manuals? I thought it didn't.
This comment has been minimized.
This comment has been minimized.
|
It would be good to ship uncompressed man pages |
alarcher commentedJan 19, 2017