New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump valgrind to 3.12.0 #2929

Merged
merged 1 commit into from Apr 5, 2017

Conversation

Projects
None yet
3 participants
@alarcher
Contributor

alarcher commented Mar 29, 2017

No description provided.

@xen0l

xen0l approved these changes Mar 29, 2017

@pyhalov

This comment has been minimized.

Contributor

pyhalov commented Mar 29, 2017

gmake test fails to compile tests:

valgrind-3.12.0/memcheck/tests/badjump2.c:21:21: error: storage size of ‘sigsegv_new’ isn’t know
...
@alarcher

This comment has been minimized.

Contributor

alarcher commented Mar 30, 2017

Fixed with -D__EXTENSIONS__ but other issues related to asm. I do not know this type of things (yet).

@alarcher alarcher force-pushed the alarcher:valgrind312 branch from a46ae6c to 1c4f1cd Apr 5, 2017

@alarcher

This comment has been minimized.

Contributor

alarcher commented Apr 5, 2017

Fixed with -std=gnu99 for asm only defined as GNU extension.

file path=usr/include/valgrind/callgrind.h
file path=usr/include/valgrind/config.h

This comment has been minimized.

@pyhalov

pyhalov Apr 5, 2017

Contributor

Comment on upper part of valgrind.p5m : what is the point of having isaexec symlinks an delivering only 64-bit version? I'd dropped them and delivered just 64-bit binaries in /usr/bin . 'CONFIGURE_BINDIR.64 = $(CONFIGURE_PREFIX)/bin' can help.

@pyhalov pyhalov added needs_work and removed ready_for_merge labels Apr 5, 2017

@alarcher alarcher force-pushed the alarcher:valgrind312 branch from 1c4f1cd to 8938a06 Apr 5, 2017

@alarcher

This comment has been minimized.

Contributor

alarcher commented Apr 5, 2017

Just dates back to the time when we did not authorize 64bit in /usr/bin. Should be OK now.

COMPONENT_SUMMARY= Valgrind: instrumentation framework and tools to detect memory and threading problems
COMPONENT_BUGDB= developer/debug/valgrind
COMPONENT_LICENSE= GPLv2
COMPONENT_LICENSE_FILE= $(COMPONENT_NAME).license


include $(WS_TOP)/make-rules/prep.mk

This comment has been minimized.

@pyhalov

pyhalov Apr 5, 2017

Contributor

Sorry.. Please, switch to $(WS_MAKE_RULES) :)

@alarcher alarcher force-pushed the alarcher:valgrind312 branch from 8938a06 to 1730303 Apr 5, 2017

@alarcher

This comment has been minimized.

Contributor

alarcher commented Apr 5, 2017

Done.

@pyhalov

pyhalov approved these changes Apr 5, 2017

@pyhalov pyhalov removed the needs_work label Apr 5, 2017

@pyhalov pyhalov merged commit 0ebd025 into OpenIndiana:oi/hipster Apr 5, 2017

@alarcher alarcher deleted the alarcher:valgrind312 branch Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment