Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtool and pkg-config should skip linker default paths #3943

Merged
merged 6 commits into from Feb 1, 2018

Conversation

@normjacobs
Copy link
Contributor

normjacobs commented Jan 31, 2018

The first changeset is unrelated, but addressed the case where the build overwrites log files from component directories that end in the same name.
The next changeset patches libtool so that it drops linker default paths instead of adding them to RPATH
Then there is a pkglint check for linker default paths in RUNPATH
A userland-mangler change to strip linker default paths from R
PATH
Finally, two changesets to make sure pkg-config has all of the linker default paths when configured and to patch it to drop -R, -rpath, and -Wl, variants for --libs where the path is in the linker defaults.

A full build with and without the new libtool and pkg-config installed shows that fixing libtool and pkg-config addresses roughly half of the RPATH issues across the gate. I didn't go back and autoreconf things that weren't addressed, but I expect that would fix some more. The userland-mangler change fixes things that weren't addressed in the component builds. It emits a message to stderr (so in the log) letting you know when it makes RPATH adjustments.

@pyhalov
Copy link
Contributor

pyhalov commented Jan 31, 2018

Thanks. One style issue - bump COMPONENT_REVISION in components which you change.

@pyhalov pyhalov requested review from xen0l and alarcher Jan 31, 2018
@alarcher
Copy link
Contributor

alarcher commented Jan 31, 2018

@jacobs Thanks for working on this! I have rebuilt the entire oi-userland with the initial patch to userland-mangler that you shared.
@pyhalov Provided that this is the same as I have tested +1 for me. I guess @xen0l will comment further.

@normjacobs normjacobs force-pushed the normjacobs:oi/hipster branch from 1c55fd1 to 157e407 Jan 31, 2018
@normjacobs
Copy link
Contributor Author

normjacobs commented Jan 31, 2018

I added the libtool and pkg-config COMPONENT_REVISION Makefile changes requested and pushed the recommitted changesets up to my github repo.

@normjacobs normjacobs force-pushed the normjacobs:oi/hipster branch from 70a1d95 to 157e407 Feb 1, 2018
@xen0l
xen0l approved these changes Feb 1, 2018
@pyhalov pyhalov merged commit 5314cea into OpenIndiana:oi/hipster Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.