Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uplibtool and pkg-config should skip linker default paths #3943
Conversation
|
Thanks. One style issue - bump COMPONENT_REVISION in components which you change. |
|
I added the libtool and pkg-config COMPONENT_REVISION Makefile changes requested and pushed the recommitted changesets up to my github repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
normjacobs commentedJan 31, 2018
The first changeset is unrelated, but addressed the case where the build overwrites log files from component directories that end in the same name.
The next changeset patches libtool so that it drops linker default paths instead of adding them to RPATH
Then there is a pkglint check for linker default paths in RUNPATH
A userland-mangler change to strip linker default paths from RPATH
Finally, two changesets to make sure pkg-config has all of the linker default paths when configured and to patch it to drop -R, -rpath, and -Wl, variants for --libs where the path is in the linker defaults.
A full build with and without the new libtool and pkg-config installed shows that fixing libtool and pkg-config addresses roughly half of the RPATH issues across the gate. I didn't go back and autoreconf things that weren't addressed, but I expect that would fix some more. The userland-mangler change fixes things that weren't addressed in the component builds. It emits a message to stderr (so in the log) letting you know when it makes RPATH adjustments.