Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upenchant: 64-bit version should not look at 32-bit modules #3994
Conversation
|
Seems to be a correct fix. However, why do we need to introduce libexecdir, when we can use libdir for this purpose? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
alarcher commentedFeb 14, 2018
•
edited
Using pluma as 64-bit I found out that enchant tries to load 32-bit modules.
There is a piece of code that unconditionally appends /usr/lib/enchant to the list of module paths.
Since ENCHANT_GLOBAL_MODULE_DIR is already specified there is no need to do so.
I should mention that in the 32-bit case the module directory was appended twice.