Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncdu: Add new package #4039

Merged
merged 1 commit into from Mar 13, 2018
Merged

ncdu: Add new package #4039

merged 1 commit into from Mar 13, 2018

Conversation

@hliebel
Copy link
Contributor

hliebel commented Mar 11, 2018

No description provided.

Copy link
Contributor

AndWac left a comment

Remove the COMPONENT_REVISION because this will be the first release of the package under the version 1.13. Setting (or increasing) the COMPONENT_REVISION is only needed if you provide changes to the installation without changing the COMPONENT_VERSION in order to make it distinquishable from older revsions with the same version.


CFLAGS += -I/usr/include/ncurses

CONFIGURE_BINDIR.64 = $(CONFIGURE_BINDIR.32)

This comment has been minimized.

Copy link
@alarcher

alarcher Mar 11, 2018

Contributor

You can use PREFERRED_BITS=64 instead of Line 39. Place it just before "include ../../../make-rules/shared-macros.mk"

@hliebel hliebel force-pushed the hliebel:hl/add-ncdu branch from bd5a4ec to c9b6427 Mar 12, 2018
@hliebel
Copy link
Contributor Author

hliebel commented Mar 12, 2018

Hi.
I made the changes, did a 'git amend' and 'force pushed' to my branch again. It that what I'm supposed to do or does that break the flow?

Do you get notified automatically if I push an update or am I supposed to write a comment?

Thanks,
Harry

CFLAGS += -I/usr/include/ncurses

# Enable Address Space Layout Randomization
ASLR_MODE = $(ASLR_ENABLE)

This comment has been minimized.

Copy link
@pyhalov

pyhalov Mar 12, 2018

Contributor

This directive is no-op on illumos, you can remove it.

@hliebel hliebel force-pushed the hliebel:hl/add-ncdu branch from c9b6427 to 5608a36 Mar 13, 2018
@pyhalov pyhalov merged commit 82272a4 into OpenIndiana:oi/hipster Mar 13, 2018
@hliebel hliebel deleted the hliebel:hl/add-ncdu branch Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.